Add Redis secrets extension #2101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthchr
requested review from
davefellows,
theunrepentantgeek,
Porges and
babbageclunk
as code owners
theunrepentantgeek
approved these changes
Feb 17, 2022
Comment on lines
+78
to
+99
| func secretsSpecified(obj *redis.Redis) (bool, bool) { | ||
| if obj.Spec.OperatorSpec == nil || obj.Spec.OperatorSpec.Secrets == nil { | ||
| return false, false | ||
| } | ||
|
|
||
| secrets := obj.Spec.OperatorSpec.Secrets | ||
| hasSecrets := false | ||
| hasEndpoints := false | ||
|
|
||
| if secrets.PrimaryKey != nil || | ||
| secrets.SecondaryKey != nil { | ||
| hasSecrets = true | ||
| } | ||
|
|
||
| if secrets.HostName != nil || | ||
| secrets.Port != nil || | ||
| secrets.SSLPort != nil { | ||
| hasEndpoints = true | ||
| } | ||
|
|
||
| return hasSecrets, hasEndpoints | ||
| } |
There was a problem hiding this comment.
Not for this PR, but perhaps we should consider generating this, adding as a function on Spec at the same time we add the Secrets property.
There was a problem hiding this comment.
We could, although we need to make the azure-arm.yaml config a bit more intelligent then in order to do it, as we have to classify secrets that come from the ListSecrets call vs "secrets" that come from the Status and are just there for convenience.
This gets extra complicated with Cosmos where there are actually 2 list secrets calls and 3 categories (secrets, readonly secrets, and endpoints).
I'll make a note to look into it though
matthchr
force-pushed
the
feature/redis-secrets
branch
from
6e9d635 to
6c800af
Compare
|
/ok-to-test sha=6c800af |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If applicable: