Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial OpenTelemetry logging and tracing support for SDK #1880

Closed
wants to merge 1 commit into from

Conversation

HaofanLiao
Copy link

  1. Add initial OpenTelemetry tracing support in RestClient.cs
  2. Add OpenTelemetrySample.csproj

Verified

This commit was signed with the committer’s verified signature.
ljharb Jordan Harband
2. Add OpenTelemetrySample.csproj
@Y-Sindo
Copy link
Member

Y-Sindo commented Dec 18, 2023

Management SDK has two transport types: Transient(REST API), Persistent(WebSockets). Basically, they have the same functionalities. Is it better to add the OpenTelemetry logging and tracing on the IServiceHubLifetimeManager level, which has two impl RestHubLifetimeManager<THub> and WebSocketsHubLifetimeManager<THub> ?

@@ -19,6 +19,7 @@
<MicrosoftIdentitiyModelClientsActiveDirectoryPackageVersion>3.19.1</MicrosoftIdentitiyModelClientsActiveDirectoryPackageVersion>
<MicrosoftAzureKeyVaultPackageVersion>2.3.2</MicrosoftAzureKeyVaultPackageVersion>
<SystemBuffersPackageVersion>4.5.1</SystemBuffersPackageVersion>
<SystemDiaDiagnosticsDiagnosticSourcePackageVersion>6.0.1</SystemDiaDiagnosticsDiagnosticSourcePackageVersion>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also add the dependency for other frameworks including 7.0, 8.0?

@HaofanLiao HaofanLiao closed this Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants