Add retryable Fact/Theory #2133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencefan
force-pushed
the
tefa/add-retryable-theory
branch
2 times, most recently
from
fdd2046 to
c2aa991
Compare
vicancy
approved these changes
Jan 21, 2025
terencefan
force-pushed
the
tefa/add-retryable-theory
branch
from
c2aa991 to
d51f502
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the test files and workflow configurations. The primary focus is on improving code quality, updating dependencies, and ensuring consistency across the tests.
Test Code Improvements:
test/Microsoft.Azure.SignalR.Common.Tests/BackOffPolicyFacts.cs: ReplacedFactwithRetryFactfor better test reliability, made various fieldsreadonly, and used simplified object initialization. [1] [2] [3] [4] [5] [6]test/Microsoft.Azure.SignalR.Common.Tests/CustomizedTimerTests.cs: ChangedTheorytoRetryTheory, removed unnecessary namespace declaration, and updated the class to use constructor injection forITestOutputHelper. [1] [2]test/Microsoft.Azure.SignalR.IntegrationTests/MessageOrderTests.cs: Refactored theMessageOrderTestsclass to use constructor injection forITestOutputHelper, added a new method to handle broadcasting and hot reloading, and updated existing test methods for better readability and consistency. [1] [2] [3] [4]Workflow Configuration:
.github/workflows/ubuntu.yml: Removed the9.0.xversion from thedotnet-versionmatrix to streamline the testing process.