Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final set of edits #643

Merged
merged 10 commits into from
Oct 10, 2019
Merged

Final set of edits #643

merged 10 commits into from
Oct 10, 2019

Conversation

normesta
Copy link
Contributor

@normesta normesta commented Oct 3, 2019

It apppears as though someone already removed the AzCopy delineators from each command example. I updated only help strings. I also compiled AzCopy to ensure that I did not introduce any errors. I pull from the latest "dev" branch, so this PR shouldn't introduce any conflicts.

@adreed-msft
Copy link
Member

Is this not just an extension of your other PR?

cmd/copy.go Outdated Show resolved Hide resolved
cmd/copy.go Outdated Show resolved Hide resolved
cmd/helpMessages.go Outdated Show resolved Hide resolved
cmd/helpMessages.go Outdated Show resolved Hide resolved
The sync command differs from the copy command in several ways:

1. The recursive flag is on by default.
2. The source and destination should not contain patterns (For example: * or ?).
Copy link
Member

@adreed-msft adreed-msft Oct 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zezha-msft this is incorrect information. (# 1)
@normesta consider rewording this "sync can copy directories without the recursive flag, but will not sync sub-directories" #Resolved

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The term "subdirectory" has no hyphen. Other than that, I've updated the text with your suggestion.

Copy link
Member

@JohnRusk JohnRusk Oct 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what's happening here: the old # 1 (the one about source and destination should not contain patterns) is indeed obsolete and should have been removed. Because now both copy and sync are the same in that regard. (I.e. it should not be the new # 2, it should be gone).

But I think its important that the new # 1, should start with "The recursive flag is on by default", since this is indeed the opposite of what copy does. E.g "1. The recursive flag is on by default. "

cmd/helpMessages.go Outdated Show resolved Hide resolved
cmd/helpMessages.go Outdated Show resolved Hide resolved
Copy link
Member

@adreed-msft adreed-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

@normesta normesta requested a review from adreed-msft October 4, 2019 21:43
cmd/copy.go Outdated Show resolved Hide resolved
@adreed-msft adreed-msft dismissed their stale review October 7, 2019 17:15

revoking review

Copy link
Member

@adreed-msft adreed-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

@adreed-msft
Copy link
Member

Fix up the syntax error and you're good 👍

cmd/copy.go Outdated Show resolved Hide resolved
cmd/copy.go Outdated Show resolved Hide resolved
cmd/copy.go Outdated Show resolved Hide resolved
cmd/copy.go Outdated Show resolved Hide resolved
cmd/copy.go Outdated Show resolved Hide resolved
@@ -1319,7 +1319,8 @@ func init() {
// options change how the transfers are performed
cpCmd.PersistentFlags().Float64Var(&raw.blockSizeMB, "block-size-mb", 0, "Use this block size (specified in MiB) when uploading to Azure Storage, and downloading from Azure Storage. The default value is automatically calculated based on file size. Decimal fractions are allowed (For example: 0.25).")
cpCmd.PersistentFlags().StringVar(&raw.logVerbosity, "log-level", "INFO", "Define the log verbosity for the log file, available levels: INFO(all requests/responses), WARNING(slow responses), ERROR(only failed requests), and NONE(no output logs). (default 'INFO').")
cpCmd.PersistentFlags().StringVar(&raw.blobType, "blob-type", "Detect", "Defines the type of blob at the destination. This is used for uploading blobs and when copying between accounts (default 'None').")
cpCmd.PersistentFlags().StringVar(&raw.blobType, "blob-type", "Detect", "Defines the type of blob at the destination. This is used for uploading blobs and when copying between accounts (default 'Detect'). Valid values include 'Detect', 'BlockBlob', 'PageBlob', and 'AppendBlob'. "+
"When copying between accounts, a value of 'Detect' causes AzCopy to use the type of source blob to determine the type of the destination blob. When uploading a file, 'Detect' determines if the file is a VHD or a VHDX file based on the file extension. If the file is ether a VHD or VHDX file, AzCopy treats the file as a page blob.")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice wording. Way better than anything I've had in emails and discussions on this feature!

cmd/helpMessages.go Show resolved Hide resolved
@JohnRusk JohnRusk self-requested a review October 10, 2019 18:59
@JohnRusk JohnRusk merged commit 20af4ff into Azure:dev Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants