Fix the issue when ranges may be losted when copying page blob/file with ServiceSideSyncCopy. #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith ServiceSideSyncCopy. Add cases to test transferring large blob/file
EmmaZhu
changed the title
blueww
reviewed
Nov 19, 2020
| @@ -26,7 +26,7 @@ | |||
| </PropertyGroup> | |||
|
|
|||
| <ItemGroup> | |||
| <Compile Include="..\..\lib\**\*.cs;..\..\tools\AssemblyInfo\*.cs" Exclude="bin\**;obj\**;**\*.xproj;packages\**" /> | |||
| <Compile Include="..\..\lib\**\*.cs;..\..\tools\AssemblyInfo\*.cs" Exclude="bin\**;obj\**;**\*.xproj;packages\**;..\..\lib\obj\**" /> | |||
There was a problem hiding this comment.
Please add Jason to review before official release
There was a problem hiding this comment.
Of cause, I've also sent CR to Jason.
There was a problem hiding this comment.
Discussed offline, ....\lib\obj** represents temporary .cs files generated during build .net version dmlib. It is fine to exclude for this project for now.
Later, we should change the Include method to filename.cs instead of *.cs.
blueww
approved these changes
Nov 19, 2020
…ServiceSideSyncCopy between pageblob/file.
JasonYang-MSFT
approved these changes
Nov 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the issue when ranges may be losted when copying page blob/file with ServiceSideSyncCopy.
Fix a build issue which is caused by compiling a build intermediate file. // This is to exclude the build intermediate cs file to avoid build failure.