Make TransferRequest timeouts editable with reflection #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am a Relativity engineer, we are using Data Movement library to transfer huge portions of data. We experience failures for slower networks and bigger files. We were able to solve this by overriding those timeouts with reflection, unfortunately this doesn't work on .net core as those properties are marked 'readonly'. Alternatively I could make this properly and expose those parameters to client, although for our usecase this is sufficient.
|
@amnguye can you take a look at this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am a Relativity engineer, we are using Data Movement library to transfer huge portions of data. We experience failures for slower networks and bigger files. We were able to solve this by overriding those timeouts with reflection, unfortunately this doesn't work on .net core as those properties are marked 'readonly'. Alternatively I could make this properly and expose those parameters to client, although for our usecase this is sufficient.