Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update underscore to 1.12.1 #677

Merged
merged 1 commit into from
Apr 28, 2021

Conversation

HarshaNalluru
Copy link
Member

Component Governance from DevOps complains of the underscore dependency in azure-sdk-for-js repo.

  • Pulled in by event-processor-host since it depends on azure-storage
  • Need to update underscore to ^1.12.1 to fix the problem

@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.696% when pulling 35c3a76 on HarshaNalluru:harshan/update-underscore into 333c924 on Azure:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.696% when pulling 35c3a76 on HarshaNalluru:harshan/update-underscore into 333c924 on Azure:master.

@@ -29,7 +29,7 @@
"md5.js": "1.3.4",
"readable-stream": "~2.0.0",
"request": "^2.86.0",
"underscore": "~1.8.3",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@XiaoningLiu Do you recall any reason why ~ was used here instead of ^
Am wondering if us making this change will cause any issues

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ramya-rao-a , @XiaoningLiu , could we run some integration tests in order to validate this security fix?

Copy link

@goelankit goelankit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the package version as well. We are looking to consume this change downstream as we are getting security alerts as well for this dependency.

@XiaoningLiu XiaoningLiu merged commit 126bbf6 into Azure:master Apr 28, 2021
@phawxby
Copy link

phawxby commented May 6, 2021

@XiaoningLiu without a package update this merge isn't helping anyone.

@joaomoreno
Copy link

@HarshaNalluru Let's release this.

@EmmaZhu
Copy link
Member

EmmaZhu commented May 7, 2021

Hi,
We are working on a release for this. Should be able to release it in the next two weeks.

Thanks
Emma

@bsegault
Copy link

bsegault commented May 7, 2021

@EmmaZhu @XiaoningLiu Can we help in any way to speed up the release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants