-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update underscore to 1.12.1 #677
Update underscore to 1.12.1 #677
Conversation
1 similar comment
@@ -29,7 +29,7 @@ | |||
"md5.js": "1.3.4", | |||
"readable-stream": "~2.0.0", | |||
"request": "^2.86.0", | |||
"underscore": "~1.8.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@XiaoningLiu Do you recall any reason why ~ was used here instead of ^
Am wondering if us making this change will cause any issues
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ramya-rao-a , @XiaoningLiu , could we run some integration tests in order to validate this security fix?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the package version as well. We are looking to consume this change downstream as we are getting security alerts as well for this dependency.
@XiaoningLiu without a package update this merge isn't helping anyone. |
@HarshaNalluru Let's release this. |
Hi, Thanks |
@EmmaZhu @XiaoningLiu Can we help in any way to speed up the release? |
Component Governance from DevOps complains of the underscore dependency in azure-sdk-for-js repo.