Allow http binding to both poco and HttpRequestMessage. #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiocav
reviewed
Aug 29, 2017
| if (parameter.ParameterType == typeof(HttpRequestMessage)) | ||
| { | ||
| // Not already claimed by another trigger? | ||
| if (parameter.GetCustomAttributes(false).Length == 0) |
There was a problem hiding this comment.
Should we be more specific on the type of attribute here (verify this is indeed a binding attribute so we still allow for other attributes)?
| { | ||
| throw new ArgumentNullException(nameof(context)); | ||
| } | ||
| var request = context.BindingData["$request"]; |
There was a problem hiding this comment.
Didn't we have constants with special binding data names somewhere? Would be good to move this there.
This was referenced Sep 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #273
Script had special logic to allow this for CSX; but VS tooling and direct SDK users didn't have the same logic. Add the httprequest binding logic in the binding.