Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ServiceBus/EventHub listener shutdown #1760

Closed
mathewc opened this issue Jun 19, 2018 · 3 comments
Closed

Improve ServiceBus/EventHub listener shutdown #1760

mathewc opened this issue Jun 19, 2018 · 3 comments
Assignees
@mathewc
Milestone
Functions Sprint 27

Comments

@mathewc
Copy link
Member

mathewc commented Jun 19, 2018 •
edited
Loading

Recent changes addressing work item #1703 now log all background errors coming from the SB MessageReceiver. This works in ensuring errors are logged during message processing.

However, during normal host shutdown, it seems disposal ordering is causing spurious errors to be logged, when there isn't a problem. E.g. the host is shutting down, the listener is stopped/disposed, and the MessageReceiver attempts one final receive operation but fails because everything is being disposed. See ICM incident #73280007.

We should clean this up so that these errors aren't logged when the host is being disposed.

See related issue: #1784
@mathewc
Copy link
Member Author

mathewc commented Jun 28, 2018

Check EventHub listener shutdown as well, since it follows the same eventing pattern

@mathewc mathewc changed the title Improve ServiceBus listener shutdown Improve ServiceBus/EventHub listener shutdown Jun 28, 2018
@mathewc mathewc self-assigned this Jun 29, 2018
mathewc added a commit that referenced this issue Jul 3, 2018
@mathewc
Improvements to EventHub/ServiceBus error handling (#1784, #1760)
e721347
@mathewc mathewc mentioned this issue Jul 3, 2018
Merged
mathewc added a commit that referenced this issue Jul 3, 2018
@mathewc
Improvements to EventHub/ServiceBus error handling (#1784, #1760)
5c25c4a
mathewc added a commit that referenced this issue Jul 3, 2018
@mathewc
Improvements to EventHub/ServiceBus error handling (#1784, #1760)
c731190
mathewc added a commit that referenced this issue Jul 3, 2018
@mathewc
Improvements to EventHub/ServiceBus error handling (#1784, #1760)
e447235
@fabiocav
Copy link
Member

fabiocav commented Jul 5, 2018

@mathewc is this done? The PR has been merged.

@mathewc
Copy link
Member Author

mathewc commented Jul 6, 2018

The issue is still open because I haven't merged this to dev yet, only v2.x. I'll do that today

@brettsam brettsam added this to the Functions Sprint 27 milestone Jul 6, 2018
mathewc added a commit that referenced this issue Jul 10, 2018
@mathewc
Improvements to EventHub/ServiceBus error handling (#1784, #1760)
dc489f4
mathewc added a commit that referenced this issue Jul 10, 2018
@mathewc
Improvements to EventHub/ServiceBus error handling (#1784, #1760)
10df564
@mathewc mathewc closed this as completed Jul 10, 2018
@fabiocav fabiocav mentioned this issue Apr 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mathewc mathewc

Labels
None yet
Projects
None yet
Milestone
Functions Sprint 27
Development

No branches or pull requests
3 participants
@mathewc @brettsam @fabiocav