making TextWriterTraceAdapter synchronized #1043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathewc
reviewed
Mar 6, 2017
|
|
||
| public override void Write(char value) | ||
| { | ||
| // buffer all output | ||
| _text.Append(value); | ||
|
|
||
| int len = _text.Length; | ||
| if (len > 2 && _text[len - 2] == '\r' && _text[len - 1] == '\n') | ||
| if (len >= 2 && _text[len - 2] == '\r' && _text[len - 1] == '\n') |
There was a problem hiding this comment.
In my test, I just log WriteLine(string.Empty) -- which looks like it just sends '\r\n'. In that case, the string length was only 2, so this logic didn't kick in like I would have expected. Instead, it waited until it had '\r\n\r\n' before flushing. It's a minor change -- but I thought it made sense.
mathewc
reviewed
Mar 6, 2017
| TextWriter adapter = TextWriterTraceAdapter.Synchronized(trace); | ||
|
|
||
| // Start Tasks to write | ||
| List<Task> tasks = new List<Task>(); |
There was a problem hiding this comment.
Did this test repro the problem reliably?
mathewc
approved these changes
Mar 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1042