Fix 1296 #1149
Closed
Fix 1296 #1149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamaso
approved these changes
May 22, 2017
| @@ -156,7 +156,8 @@ public void Validate() | |||
| { | |||
| if (this.StartTime > this.EndTime) | |||
| { | |||
| throw new InvalidOperationException("End Time must be greater than start time"); | |||
| // This can happen in rare cases if the clock adjusts while the function is running. | |||
| this.EndTime = this.StartTime.AddMilliseconds(1); | |||
There was a problem hiding this comment.
Do we prefer this over removing the validation check altogether? I suppose the dashboard or other consumers might throw up if they see endtime < starttime.
|
merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Azure/azure-functions-host#1296
Need to be resilient to clock adjustment in the middle of a running function.
Tactical fix - eventually this all gets removed and replaced with AI