adding utility to make binding resolution easier for custom IResolutionPolicy authors #1576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathewc
reviewed
Feb 15, 2018
| /// <param name="token">A token string to resolve from the binding data. For example, "a.b.c".</param> | ||
| /// <param name="bindingData">The binding data to resolve the parameter against.</param> | ||
| /// <returns>The resolved parameter.</returns> | ||
| public static string ResolveToken(string token, IReadOnlyDictionary<string, object> bindingData) |
There was a problem hiding this comment.
Is this equivalent to the below? Wondering who is going to use this new method and if the below isn't sufficient.
var template = BindingTemplate.FromString(token);
var resolved = template.Bind(bindingData);
MikeStall
reviewed
Feb 15, 2018
| } | ||
|
|
||
| [Fact] | ||
| public void ResolveToken() |
MikeStall
approved these changes
Feb 15, 2018
|
@brettsam Can this be closed? |
|
Yeah, the issue is captured in #1726. I put this together first before we realized it required much larger changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.