Exception logging for MessageReceiver background exceptions #1704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathewc
force-pushed
the
mathewc-work-v2.x
branch
from
8cdcf08 to
b9e54ef
Compare
mathewc
commented
May 17, 2018
| int deliveryCount, | ||
| ILogger log) | ||
| { | ||
| log.LogInformation($"Processing ServiceBus message (Id={messageId}, DeliveryCount={deliveryCount})"); |
There was a problem hiding this comment.
I used this sample function to repro the issue. Before my changes, if I introduced a 7 minute delay in this function, the lock would be lost and I'd get retries without any error messages. With my changes the MessageLockLostException from SB is logged to console.
mathewc
commented
May 17, 2018
| { | ||
| if (!e.Exception.IsWrappedExceptionTransient()) | ||
| { | ||
| context.Trace.Error($"MessageReceiver error (Action={e.Action})", e.Exception); |
There was a problem hiding this comment.
I'm assuming that the TraceWriter is all wired up to AppInsights if AI is enabled @brettsam ?
There was a problem hiding this comment.
In v2.x, you need to do the ugly double-logging to both TraceWriter and ILogger. In dev it's just ILogger
There was a problem hiding this comment.
Updated to conditionally log to ILogger as well :)
brettsam
approved these changes
May 17, 2018
mathewc
force-pushed
the
mathewc-work-v2.x
branch
from
b9e54ef to
48aebe5
Compare
This was referenced May 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1703
I'll be making similar changes in v2