Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding EnableSqlCommandTextInstrumentation to ApplicationInsightsLoggerOptions #2608

Merged
merged 4 commits into from
Oct 27, 2020
Merged

Adding EnableSqlCommandTextInstrumentation to ApplicationInsightsLoggerOptions #2608

merged 4 commits into from
Oct 27, 2020

Conversation

soninaren
Copy link
Member

Resolves #2548

@soninaren soninaren requested a review from brettsam October 18, 2020 09:49
@soninaren soninaren force-pushed the developer/nasoni/sqlInstrumentation branch from 11e676f to dc92938 Compare October 18, 2020 09:51
@soninaren soninaren force-pushed the developer/nasoni/sqlInstrumentation branch from dc92938 to 40331a1 Compare October 20, 2020 10:15
@brettsam brettsam mentioned this pull request Oct 23, 2020
Closed
brettsam
brettsam approved these changes Oct 27, 2020
View reviewed changes
src/Microsoft.Azure.WebJobs.Logging.ApplicationInsights/ApplicationInsightsLoggerOptions.cs
@@ -105,6 +106,11 @@ public string QuickPulseAuthenticationApiKey
/// </summary>
public bool EnableDependencyTracking { get; set; } = true;

/// <summary>
/// Configuration for dependency tracking. The dependecny tracking configuration only takes effect if EnableDependencyTracking is set to true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit -- spelling of dependecny

src/Microsoft.Azure.WebJobs.Logging.ApplicationInsights/DependencyTrackingOptions.cs Show resolved Hide resolved
@soninaren soninaren merged commit 1760cf1 into dev Oct 27, 2020
@soninaren soninaren deleted the developer/nasoni/sqlInstrumentation branch October 27, 2020 23:17
@brettsam
Copy link
Member

@soninaren -- we'll need to pull this into the host and make sure it binds as expected to host.json

@Kapkan-Lesion
Copy link

Kapkan-Lesion commented Nov 2, 2020 •
edited
Loading

@brettsam @soninaren
Hi! Why should we expect this to become publicly available? Am desperately looking for a way to turn SQL commands back on in my Azure Function's App Insights!

@brettsam
Copy link
Member

brettsam commented Nov 2, 2020

It will be part of the next Functions release. Likely worldwide in a few weeks.

@Kapkan-Lesion
Copy link

@brettsam Hey Brett, apologies for chasing this feature, when will this feature become available? I understand that you guys have a lot going on especially during this pandemic, just wanted to say thanks for the hard work!

@soninaren
Copy link
Member Author

@Kapkan-Lesion This should be available for function runtime version 3.0.15027 or higher.

@brettsam brettsam mentioned this pull request Mar 22, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettsam brettsam brettsam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ability to turn on SQL query logging for Azure Functions
3 participants
@soninaren @brettsam @Kapkan-Lesion