Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

infra: Add appinsights logging step for sample run results #2818

Open
wants to merge 32 commits into
base: main
Choose a base branch
from
Open

infra: Add appinsights logging step for sample run results #2818

wants to merge 32 commits into from

Conversation

diondrapeck
Copy link
Contributor

Description

Checklist

  • I have read the contribution guidelines.
  • I have coordinated with the docs team (mldocs@microsoft.com) if this PR deletes files or changes any file names or file extensions.
  • Pull request includes test coverage for the included changes.
  • This notebook or file is added to the CODEOWNERS file, pointing to the author or the author's team.

@diondrapeck diondrapeck marked this pull request as draft November 9, 2023 19:24
@diondrapeck diondrapeck marked this pull request as ready for review November 10, 2023 00:00
kdestin
kdestin reviewed Nov 10, 2023
View reviewed changes
Copy link
Member

@kdestin kdestin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's a tutorials/readme.py that might also need to be updated.

sdk/python/readme.py Outdated Show resolved Hide resolved
sdk/python/readme.py Outdated Show resolved Hide resolved
cli/readme.py Outdated Show resolved Hide resolved
sdgilley
sdgilley previously approved these changes Nov 11, 2023
View reviewed changes
Copy link
Contributor

@sdgilley sdgilley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs approval. None of these changes will break our build.

kdestin
kdestin previously approved these changes Nov 16, 2023
View reviewed changes
@diondrapeck diondrapeck dismissed stale reviews from kdestin and sdgilley via e2eef18 March 28, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbsolo-ms1 fbsolo-ms1 fbsolo-ms1 approved these changes

@sdgilley sdgilley sdgilley left review comments

@kdestin kdestin kdestin left review comments

@msakande msakande Awaiting requested review from msakande

@Blackmist Blackmist Awaiting requested review from Blackmist

@ssalgadodev ssalgadodev Awaiting requested review from ssalgadodev

@lgayhardt lgayhardt Awaiting requested review from lgayhardt

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@diondrapeck @sdgilley @kdestin @fbsolo-ms1