Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update distillation job with sdk example #3440

Merged
merged 15 commits into from
Nov 20, 2024

Conversation

sanchez-alex
Copy link
Contributor

@sanchez-alex sanchez-alex commented Nov 7, 2024

Description

Checklist

  • I have read the contribution guidelines.
  • I have coordinated with the docs team (mldocs@microsoft.com) if this PR deletes files or changes any file names or file extensions.
  • Pull request includes test coverage for the included changes.
  • This notebook or file is added to the CODEOWNERS file, pointing to the author or the author's team.

@kingernupur
Copy link
Member

@sanchez-alex Have you added workflows for these new notebooks?

@sanchez-alex
Copy link
Contributor Author

@sanchez-alex Have you added workflows for these new notebooks?
One of these notebooks has a workflow already, the rest of them do not have a workflow to avoid too many inference requests to the MaaS endpoint

hakotesova
hakotesova previously approved these changes Nov 18, 2024
@jayesh-tanna
Copy link
Member

Consider to add team ownership entry into notebook owning file.

msp8955
msp8955 previously approved these changes Nov 19, 2024
@sanchez-alex
Copy link
Contributor Author

Consider to add team ownership entry into notebook owning file.

Ownership entry in notebook owning file already there

@msp8955
Copy link
Member

msp8955 commented Nov 19, 2024

@sanchez-alex sanchez-alex dismissed stale reviews from msp8955 and hakotesova via 2e08d13 November 20, 2024 00:04
@sanchez-alex sanchez-alex merged commit 17c67f3 into main Nov 20, 2024
6 checks passed
@sanchez-alex sanchez-alex deleted the alexsanchez/distillation_sdk branch November 20, 2024 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants