Add support for monitoring specific processes #29
Conversation
Porges
force-pushed
the
master
branch
4 times, most recently
from
699dc60
to
7c525c3
Compare
| continue | ||
| } | ||
|
|
||
| cpuPercent, err := p.CPUPercent() |
There was a problem hiding this comment.
Does this work fine on windows? The main CPU usage has been implemented wrongly on windows(Or at least was when I made it, might have been fixed) I had to call wmi directly
There was a problem hiding this comment.
I saw a PR on the repo that might have fixed it recently so it might just be working fine
You can now set `AZ_BATCH_MONITOR_PROCESSES` to change the processes to monitor.
|
Can you also add docs to the readme on how to use this setting |
|
Updated docs. |
|
On windows you also need to update the |
|
@timotheeguerin yes, that's why I wrote "this will require modifying the appropriate run script". Do you think I should be more explicit? |
|
Oh I see, any reason why you wouldn't change it here? Feel like this is an unnecessary step for users |
|
Right, easy enough 🙂 |
Add a new commandline parameter which is a comma-separated list of process names to monitor. Stats for CPU and memory of these processes will be sent alongside the other metrics.