Skip to content
This repository has been archived by the owner on Oct 12, 2023. It is now read-only.

Feature: Better configuration #34

Merged
merged 28 commits into from
Mar 6, 2019
Merged

Conversation

timotheeguerin
Copy link
Member

@timotheeguerin timotheeguerin commented Feb 27, 2019

fix #32

Provide ways to configure Batch Insights via command line arguments.
Is backward compatible with previous version which took positional arguments for pool id, node id and instrumentation key.
The deprecated args will be removed in version 2.0.0

docs/configuration.md Outdated Show resolved Hide resolved
#### `--nodeID <value>`
Node ID. Override node ID provided by the `AZ_BATCH_NODE_ID` environment variable
#### `--instKey <value>`
Instrumentation key. Application insights instrumentation key to emit the metrics
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'Insights' (capital I)

docs/configuration.md Outdated Show resolved Hide resolved
docs/configuration.md Outdated Show resolved Hide resolved
docs/configuration.md Outdated Show resolved Hide resolved
docs/configuration.md Outdated Show resolved Hide resolved
main.go Show resolved Hide resolved
@timotheeguerin timotheeguerin merged commit bc81529 into master Mar 6, 2019
@timotheeguerin timotheeguerin deleted the feature/configuration branch March 6, 2019 20:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New configuration system to allow for picking which metrics to upload
2 participants