Skip to content

Commit

Permalink
fix: Rename 'capacity' property to skuCapacity in the tests - `avm/re…
Browse files Browse the repository at this point in the history
…s/sql/server` (#3318)

Fixes #1324

## Description



## Pipeline Reference

<!-- Insert your Pipeline Status Badge below -->

| Pipeline |
| -------- |
|          |

## Type of Change

<!-- Use the checkboxes [x] on the options that are relevant. -->

- [ ] Update to CI Environment or utilities (Non-module affecting
changes)
- [x] Azure Verified Module updates:
- [x] Bugfix containing backwards-compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`:
- [x] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [ ] Feature update backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [ ] Breaking changes and I have bumped the MAJOR version in
`version.json`.
  - [ ] Update to documentation

## Checklist

- [x] I'm sure there are no other open Pull Requests for the same
update/change
- [x] I have run `Set-AVMModule` locally to generate the supporting
module files.
- [ ] My corresponding pipelines / checks run clean and green without
any errors or warnings

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
  • Loading branch information
peterbud and eriqua authored Sep 27, 2024
1 parent 0324570 commit 0c00203
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
8 changes: 4 additions & 4 deletions avm/res/sql/server/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,6 @@ module server 'br/public:avm/res/sql/server:<version>' = {
backupShortTermRetentionPolicy: {
retentionDays: 14
}
capacity: 0
collation: 'SQL_Latin1_General_CP1_CI_AS'
diagnosticSettings: [
{
Expand All @@ -289,6 +288,7 @@ module server 'br/public:avm/res/sql/server:<version>' = {
licenseType: 'LicenseIncluded'
maxSizeBytes: 34359738368
name: 'sqlsmaxdb-001'
skuCapacity: 0
skuName: 'ElasticPool'
skuTier: 'GeneralPurpose'
}
Expand Down Expand Up @@ -438,7 +438,6 @@ module server 'br/public:avm/res/sql/server:<version>' = {
"backupShortTermRetentionPolicy": {
"retentionDays": 14
},
"capacity": 0,
"collation": "SQL_Latin1_General_CP1_CI_AS",
"diagnosticSettings": [
{
Expand All @@ -457,6 +456,7 @@ module server 'br/public:avm/res/sql/server:<version>' = {
"licenseType": "LicenseIncluded",
"maxSizeBytes": 34359738368,
"name": "sqlsmaxdb-001",
"skuCapacity": 0,
"skuName": "ElasticPool",
"skuTier": "GeneralPurpose"
}
Expand Down Expand Up @@ -857,7 +857,6 @@ module server 'br/public:avm/res/sql/server:<version>' = {
backupShortTermRetentionPolicy: {
retentionDays: 14
}
capacity: 0
collation: 'SQL_Latin1_General_CP1_CI_AS'
diagnosticSettings: [
{
Expand All @@ -876,6 +875,7 @@ module server 'br/public:avm/res/sql/server:<version>' = {
licenseType: 'LicenseIncluded'
maxSizeBytes: 34359738368
name: 'sqlswafdb-001'
skuCapacity: 0
skuName: 'ElasticPool'
skuTier: 'GeneralPurpose'
}
Expand Down Expand Up @@ -988,7 +988,6 @@ module server 'br/public:avm/res/sql/server:<version>' = {
"backupShortTermRetentionPolicy": {
"retentionDays": 14
},
"capacity": 0,
"collation": "SQL_Latin1_General_CP1_CI_AS",
"diagnosticSettings": [
{
Expand All @@ -1007,6 +1006,7 @@ module server 'br/public:avm/res/sql/server:<version>' = {
"licenseType": "LicenseIncluded",
"maxSizeBytes": 34359738368,
"name": "sqlswafdb-001",
"skuCapacity": 0,
"skuName": "ElasticPool",
"skuTier": "GeneralPurpose"
}
Expand Down
2 changes: 1 addition & 1 deletion avm/res/sql/server/tests/e2e/max/main.test.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ module testDeployment '../../../main.bicep' = {
collation: 'SQL_Latin1_General_CP1_CI_AS'
skuTier: 'GeneralPurpose'
skuName: 'ElasticPool'
capacity: 0
skuCapacity: 0
maxSizeBytes: 34359738368
licenseType: 'LicenseIncluded'
diagnosticSettings: [
Expand Down
2 changes: 1 addition & 1 deletion avm/res/sql/server/tests/e2e/waf-aligned/main.test.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ module testDeployment '../../../main.bicep' = {
collation: 'SQL_Latin1_General_CP1_CI_AS'
skuTier: 'GeneralPurpose'
skuName: 'ElasticPool'
capacity: 0
skuCapacity: 0
maxSizeBytes: 34359738368
licenseType: 'LicenseIncluded'
diagnosticSettings: [
Expand Down

0 comments on commit 0c00203

Please sign in to comment.