Skip to content

Commit

Permalink
feat: ACR Availability Zone Spec. (#3548)
Browse files Browse the repository at this point in the history
## Description

This PR contains the changes to deploy ACR as zone redundant by default
to meeting AVM specs.

## Pipeline Reference

<!-- Insert your Pipeline Status Badge below -->

| Pipeline |
| -------- |

|[![avm.res.container-registry.registry](https://github.com/tsc-buddy/bicep-registry-modules/actions/workflows/avm.res.container-registry.registry.yml/badge.svg)](https://github.com/tsc-buddy/bicep-registry-modules/actions/workflows/avm.res.container-registry.registry.yml)|

## Type of Change

<!-- Use the checkboxes [x] on the options that are relevant. -->

- [ ] Update to CI Environment or utilities (Non-module affecting
changes)
- [x] Azure Verified Module updates:
- [ ] Bugfix containing backwards-compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`:
- [ ] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [x] Feature update backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [ ] Breaking changes and I have bumped the MAJOR version in
`version.json`.
  - [x] Update to documentation

## Checklist

- [x] I'm sure there are no other open Pull Requests for the same
update/change
- [x] I have run `Set-AVMModule` locally to generate the supporting
module files.
- [x] My corresponding pipelines / checks run clean and green without
any errors or warnings

<!-- Please keep up to date with the contribution guide at
https://aka.ms/avm/contribute/bicep -->
  • Loading branch information
tsc-buddy authored Oct 14, 2024
1 parent b420117 commit 11fce93
Show file tree
Hide file tree
Showing 9 changed files with 29 additions and 29 deletions.
4 changes: 2 additions & 2 deletions avm/res/container-registry/registry/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -1138,7 +1138,7 @@ Tier of your Azure container registry.

- Required: No
- Type: string
- Default: `'Basic'`
- Default: `'Premium'`
- Allowed:
```Bicep
[
Expand Down Expand Up @@ -2194,7 +2194,7 @@ Whether or not zone redundancy is enabled for this container registry.

- Required: No
- Type: string
- Default: `'Disabled'`
- Default: `'Enabled'`
- Allowed:
```Bicep
[
Expand Down
4 changes: 2 additions & 2 deletions avm/res/container-registry/registry/cache-rule/main.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.29.47.4906",
"templateHash": "14369419482171687857"
"version": "0.30.3.12046",
"templateHash": "17205938486061573561"
},
"name": "Container Registries Cache",
"description": "Cache for Azure Container Registry (Preview) feature allows users to cache container images in a private container registry. Cache for ACR, is a preview feature available in Basic, Standard, and Premium service tiers ([ref](https://learn.microsoft.com/en-us/azure/container-registry/tutorial-registry-cache)).",
Expand Down
4 changes: 2 additions & 2 deletions avm/res/container-registry/registry/credential-set/main.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.29.47.4906",
"templateHash": "12196074162662855376"
"version": "0.30.3.12046",
"templateHash": "13281764602355848660"
},
"name": "Container Registries Credential Sets",
"description": "This module deploys an ACR Credential Set.",
Expand Down
4 changes: 2 additions & 2 deletions avm/res/container-registry/registry/main.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ param roleAssignments roleAssignmentType
'Premium'
'Standard'
])
param acrSku string = 'Basic'
param acrSku string = 'Premium'

@allowed([
'disabled'
Expand Down Expand Up @@ -107,7 +107,7 @@ param privateEndpoints privateEndpointType
'Enabled'
])
@description('Optional. Whether or not zone redundancy is enabled for this container registry.')
param zoneRedundancy string = 'Disabled'
param zoneRedundancy string = 'Enabled'

@description('Optional. All replications to create.')
param replications array?
Expand Down
28 changes: 14 additions & 14 deletions avm/res/container-registry/registry/main.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.29.47.4906",
"templateHash": "2885305905621743300"
"version": "0.30.3.12046",
"templateHash": "14769734612544320664"
},
"name": "Azure Container Registries (ACR)",
"description": "This module deploys an Azure Container Registry (ACR).",
Expand Down Expand Up @@ -570,7 +570,7 @@
},
"acrSku": {
"type": "string",
"defaultValue": "Basic",
"defaultValue": "Premium",
"allowedValues": [
"Basic",
"Premium",
Expand Down Expand Up @@ -715,7 +715,7 @@
},
"zoneRedundancy": {
"type": "string",
"defaultValue": "Disabled",
"defaultValue": "Enabled",
"allowedValues": [
"Disabled",
"Enabled"
Expand Down Expand Up @@ -1028,8 +1028,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.29.47.4906",
"templateHash": "9144531012597082524"
"version": "0.30.3.12046",
"templateHash": "17045733538280748766"
},
"name": "Container Registries scopeMaps",
"description": "This module deploys an Azure Container Registry (ACR) scopeMap.",
Expand Down Expand Up @@ -1155,8 +1155,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.29.47.4906",
"templateHash": "8531695368487734118"
"version": "0.30.3.12046",
"templateHash": "11507205381257602922"
},
"name": "Azure Container Registry (ACR) Replications",
"description": "This module deploys an Azure Container Registry (ACR) Replication.",
Expand Down Expand Up @@ -1303,8 +1303,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.29.47.4906",
"templateHash": "12196074162662855376"
"version": "0.30.3.12046",
"templateHash": "13281764602355848660"
},
"name": "Container Registries Credential Sets",
"description": "This module deploys an ACR Credential Set.",
Expand Down Expand Up @@ -1478,8 +1478,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.29.47.4906",
"templateHash": "14369419482171687857"
"version": "0.30.3.12046",
"templateHash": "17205938486061573561"
},
"name": "Container Registries Cache",
"description": "Cache for Azure Container Registry (Preview) feature allows users to cache container images in a private container registry. Cache for ACR, is a preview feature available in Basic, Standard, and Premium service tiers ([ref](https://learn.microsoft.com/en-us/azure/container-registry/tutorial-registry-cache)).",
Expand Down Expand Up @@ -1610,8 +1610,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.29.47.4906",
"templateHash": "14912363209364245195"
"version": "0.30.3.12046",
"templateHash": "3542060088842117365"
},
"name": "Azure Container Registry (ACR) Webhooks",
"description": "This module deploys an Azure Container Registry (ACR) Webhook.",
Expand Down
4 changes: 2 additions & 2 deletions avm/res/container-registry/registry/replication/main.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.29.47.4906",
"templateHash": "8531695368487734118"
"version": "0.30.3.12046",
"templateHash": "11507205381257602922"
},
"name": "Azure Container Registry (ACR) Replications",
"description": "This module deploys an Azure Container Registry (ACR) Replication.",
Expand Down
4 changes: 2 additions & 2 deletions avm/res/container-registry/registry/scope-map/main.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.29.47.4906",
"templateHash": "9144531012597082524"
"version": "0.30.3.12046",
"templateHash": "17045733538280748766"
},
"name": "Container Registries scopeMaps",
"description": "This module deploys an Azure Container Registry (ACR) scopeMap.",
Expand Down
2 changes: 1 addition & 1 deletion avm/res/container-registry/registry/version.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"$schema": "https://aka.ms/bicep-registry-module-version-file-schema#",
"version": "0.5",
"version": "0.6",
"pathFilters": [
"./main.json"
]
Expand Down
4 changes: 2 additions & 2 deletions avm/res/container-registry/registry/webhook/main.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.29.47.4906",
"templateHash": "14912363209364245195"
"version": "0.30.3.12046",
"templateHash": "3542060088842117365"
},
"name": "Azure Container Registry (ACR) Webhooks",
"description": "This module deploys an Azure Container Registry (ACR) Webhook.",
Expand Down

0 comments on commit 11fce93

Please sign in to comment.