Skip to content

Commit

Permalink
fix: Key Vault - Incorrect test value (#3398)
Browse files Browse the repository at this point in the history
## Description

Fixed incorrect test value in max test that was not reflecting the way
the UDTs are implemented

## Pipeline Reference

<!-- Insert your Pipeline Status Badge below -->

| Pipeline |
| -------- |
|
[![avm.res.key-vault.vault](https://github.com/Azure/bicep-registry-modules/actions/workflows/avm.res.key-vault.vault.yml/badge.svg?branch=users%2Falsehr%2FkvltParamFix&event=workflow_dispatch)](https://github.com/Azure/bicep-registry-modules/actions/workflows/avm.res.key-vault.vault.yml)
|

## Type of Change

<!-- Use the checkboxes [x] on the options that are relevant. -->

- [ ] Update to CI Environment or utilities (Non-module affecting
changes)
- [ ] Azure Verified Module updates:
- [x] Bugfix containing backwards-compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`:
- [ ] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [ ] Feature update backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [ ] Breaking changes and I have bumped the MAJOR version in
`version.json`.
  - [ ] Update to documentation
  • Loading branch information
AlexanderSehr authored Oct 15, 2024
1 parent f44015a commit 6074f32
Show file tree
Hide file tree
Showing 5 changed files with 38 additions and 22 deletions.
36 changes: 24 additions & 12 deletions avm/res/key-vault/vault/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -352,8 +352,10 @@ module vault 'br/public:avm/res/key-vault/vault:<version>' = {
enableRbacAuthorization: false
keys: [
{
attributesExp: 1725109032
attributesNbf: 10000
attributes: {
exp: 1725109032
nbf: 10000
}
name: 'keyName'
roleAssignments: [
{
Expand Down Expand Up @@ -495,8 +497,10 @@ module vault 'br/public:avm/res/key-vault/vault:<version>' = {
]
secrets: [
{
attributesExp: 1702648632
attributesNbf: 10000
attributes: {
exp: 1725109032
nbf: 10000
}
contentType: 'Something'
name: 'secretName'
roleAssignments: [
Expand Down Expand Up @@ -608,8 +612,10 @@ module vault 'br/public:avm/res/key-vault/vault:<version>' = {
"keys": {
"value": [
{
"attributesExp": 1725109032,
"attributesNbf": 10000,
"attributes": {
"exp": 1725109032,
"nbf": 10000
},
"name": "keyName",
"roleAssignments": [
{
Expand Down Expand Up @@ -763,8 +769,10 @@ module vault 'br/public:avm/res/key-vault/vault:<version>' = {
"secrets": {
"value": [
{
"attributesExp": 1702648632,
"attributesNbf": 10000,
"attributes": {
"exp": 1725109032,
"nbf": 10000
},
"contentType": "Something",
"name": "secretName",
"roleAssignments": [
Expand Down Expand Up @@ -870,8 +878,10 @@ param enablePurgeProtection = false
param enableRbacAuthorization = false
param keys = [
{
attributesExp: 1725109032
attributesNbf: 10000
attributes: {
exp: 1725109032
nbf: 10000
}
name: 'keyName'
roleAssignments: [
{
Expand Down Expand Up @@ -1013,8 +1023,10 @@ param roleAssignments = [
]
param secrets = [
{
attributesExp: 1702648632
attributesNbf: 10000
attributes: {
exp: 1725109032
nbf: 10000
}
contentType: 'Something'
name: 'secretName'
roleAssignments: [
Expand Down
4 changes: 2 additions & 2 deletions avm/res/key-vault/vault/access-policy/main.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.29.47.4906",
"templateHash": "7494731697751039419"
"version": "0.30.23.60470",
"templateHash": "15469258025112973480"
},
"name": "Key Vault Access Policies",
"description": "This module deploys a Key Vault Access Policy.",
Expand Down
4 changes: 2 additions & 2 deletions avm/res/key-vault/vault/key/main.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.30.3.12046",
"templateHash": "13039550242026782790"
"version": "0.30.23.60470",
"templateHash": "796741209006922272"
},
"name": "Key Vault Keys",
"description": "This module deploys a Key Vault Key.",
Expand Down
4 changes: 2 additions & 2 deletions avm/res/key-vault/vault/secret/main.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.29.47.4906",
"templateHash": "114626909766354577"
"version": "0.30.23.60470",
"templateHash": "10121697157844029321"
},
"name": "Key Vault Secrets",
"description": "This module deploys a Key Vault Secret.",
Expand Down
12 changes: 8 additions & 4 deletions avm/res/key-vault/vault/tests/e2e/max/main.test.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -123,8 +123,10 @@ module testDeployment '../../../main.bicep' = [
enableRbacAuthorization: false
keys: [
{
attributesExp: 1725109032
attributesNbf: 10000
attributes: {
exp: 1725109032
nbf: 10000
}
name: 'keyName'
roleAssignments: [
{
Expand Down Expand Up @@ -274,8 +276,10 @@ module testDeployment '../../../main.bicep' = [
]
secrets: [
{
attributesExp: 1702648632
attributesNbf: 10000
attributes: {
exp: 1725109032
nbf: 10000
}
contentType: 'Something'
name: 'secretName'
roleAssignments: [
Expand Down

0 comments on commit 6074f32

Please sign in to comment.