Skip to content

Commit

Permalink
fix: Added Microsoft.DevOpsInfrastructure/pools to removal order (#…
Browse files Browse the repository at this point in the history
…3516)

## Description

After observing [a few
times](https://github.com/Azure/bicep-registry-modules/actions/runs/11297815667/job/31425540661#step:4:887)
that the removal job for the module
`Microsoft.DevOpsInfrastructure/pools` failed, I figured it is time to
add it to the removal order.
The error usually happens when the removal logic tries to remove the RG
before the Pool - presumably because it breaks the resource's
dependencies (e.g., its VNET) and in turn leaves the resource also in a
broken, unremovable state.

## Pipeline Reference

<!-- Insert your Pipeline Status Badge below -->

| Pipeline |
| -------- |
|
[![avm.res.dev-ops-infrastructure.pool](https://github.com/Azure/bicep-registry-modules/actions/workflows/avm.res.dev-ops-infrastructure.pool.yml/badge.svg?branch=users%2Falsehr%2FmanagedDevOpsRemovalORder&event=workflow_dispatch)](https://github.com/Azure/bicep-registry-modules/actions/workflows/avm.res.dev-ops-infrastructure.pool.yml)
|

## Type of Change

<!-- Use the checkboxes [x] on the options that are relevant. -->

- [x] Update to CI Environment or utilities (Non-module affecting
changes)
- [ ] Azure Verified Module updates:
- [ ] Bugfix containing backwards-compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`:
- [ ] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [ ] Feature update backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [ ] Breaking changes and I have bumped the MAJOR version in
`version.json`.
  - [ ] Update to documentation
  • Loading branch information
AlexanderSehr authored Oct 13, 2024
1 parent 341743c commit 797475c
Showing 1 changed file with 1 addition and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@ function Initialize-DeploymentRemoval {
'Microsoft.ContainerInstance/containerGroups' # Must be removed before their MSI
'Microsoft.ManagedIdentity/userAssignedIdentities',
'Microsoft.Databricks/workspaces'
'Microsoft.DevOpsInfrastructure/pools' # Must be removed before other resources it depends on like a virtual network
'Microsoft.Resources/resourceGroups'
)

Expand Down

0 comments on commit 797475c

Please sign in to comment.