Skip to content

Commit

Permalink
fix: Removed telemetry parameter from RSV test (#1829)
Browse files Browse the repository at this point in the history
## Description

Removed redundant telemetry parameter from test files for RSV

## Pipeline Reference

<!-- Insert your Pipeline Status Badge below -->

| Pipeline |
| -------- |
|
[![avm.res.recovery-services.vault](https://github.com/Azure/bicep-registry-modules/actions/workflows/avm.res.recovery-services.vault.yml/badge.svg?branch=users%2Falsehr%2FrsvTelem&event=workflow_dispatch)](https://github.com/Azure/bicep-registry-modules/actions/workflows/avm.res.recovery-services.vault.yml)
|

## Type of Change

<!-- Use the check-boxes [x] on the options that are relevant. -->

- [ ] Update to CI Environment or utlities (Non-module effecting
changes)
- [ ] Azure Verified Module updates:
- [x] Bugfix containing backwards compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`:
- [ ] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [ ] Feature update backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [ ] Breaking changes and I have bumped the MAJOR version in
`version.json`.
  - [ ] Update to documentation
  • Loading branch information
AlexanderSehr authored May 28, 2024
1 parent 15aef3e commit cfbe2e3
Show file tree
Hide file tree
Showing 6 changed files with 22 additions and 54 deletions.
16 changes: 0 additions & 16 deletions avm/res/recovery-services/vault/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ module vault 'br/public:avm/res/recovery-services/vault:<version>' = {
// Required parameters
name: 'rsvmin001'
// Non-required parameters
enableTelemetry: '<enableTelemetry>'
location: '<location>'
replicationAlertSettings: {
customEmailAddresses: [
Expand Down Expand Up @@ -96,9 +95,6 @@ module vault 'br/public:avm/res/recovery-services/vault:<version>' = {
"value": "rsvmin001"
},
// Non-required parameters
"enableTelemetry": {
"value": "<enableTelemetry>"
},
"location": {
"value": "<location>"
},
Expand Down Expand Up @@ -141,7 +137,6 @@ module vault 'br/public:avm/res/recovery-services/vault:<version>' = {
// Required parameters
name: '<name>'
// Non-required parameters
enableTelemetry: '<enableTelemetry>'
location: '<location>'
replicationFabrics: [
{
Expand Down Expand Up @@ -224,9 +219,6 @@ module vault 'br/public:avm/res/recovery-services/vault:<version>' = {
"value": "<name>"
},
// Non-required parameters
"enableTelemetry": {
"value": "<enableTelemetry>"
},
"location": {
"value": "<location>"
},
Expand Down Expand Up @@ -571,7 +563,6 @@ module vault 'br/public:avm/res/recovery-services/vault:<version>' = {
workspaceResourceId: '<workspaceResourceId>'
}
]
enableTelemetry: '<enableTelemetry>'
location: '<location>'
lock: {
kind: 'CanNotDelete'
Expand Down Expand Up @@ -961,9 +952,6 @@ module vault 'br/public:avm/res/recovery-services/vault:<version>' = {
}
]
},
"enableTelemetry": {
"value": "<enableTelemetry>"
},
"location": {
"value": "<location>"
},
Expand Down Expand Up @@ -1365,7 +1353,6 @@ module vault 'br/public:avm/res/recovery-services/vault:<version>' = {
workspaceResourceId: '<workspaceResourceId>'
}
]
enableTelemetry: '<enableTelemetry>'
location: '<location>'
lock: {
kind: 'CanNotDelete'
Expand Down Expand Up @@ -1738,9 +1725,6 @@ module vault 'br/public:avm/res/recovery-services/vault:<version>' = {
}
]
},
"enableTelemetry": {
"value": "<enableTelemetry>"
},
"location": {
"value": "<location>"
},
Expand Down
44 changes: 22 additions & 22 deletions avm/res/recovery-services/vault/main.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.26.54.24096",
"templateHash": "2215975966866051299"
"version": "0.26.170.59819",
"templateHash": "1862211318279330636"
},
"name": "Recovery Services Vaults",
"description": "This module deploys a Recovery Services Vault.",
Expand Down Expand Up @@ -739,8 +739,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.26.54.24096",
"templateHash": "10579941098853248837"
"version": "0.26.170.59819",
"templateHash": "11356550125746118742"
},
"name": "Recovery Services Vault Replication Fabrics",
"description": "This module deploys a Replication Fabric for Azure to Azure disaster recovery scenario of Azure Site Recovery.\n\n> Note: this module currently support only the `instanceType: 'Azure'` scenario.",
Expand Down Expand Up @@ -818,8 +818,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.26.54.24096",
"templateHash": "16016202718205451628"
"version": "0.26.170.59819",
"templateHash": "5984264696314475505"
},
"name": "Recovery Services Vault Replication Fabric Replication Protection Containers",
"description": "This module deploys a Recovery Services Vault Replication Protection Container.\n\n> **Note**: this version of the module only supports the `instanceType: 'A2A'` scenario.",
Expand Down Expand Up @@ -901,8 +901,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.26.54.24096",
"templateHash": "16134780575393361186"
"version": "0.26.170.59819",
"templateHash": "1972024700499501510"
},
"name": "Recovery Services Vault Replication Fabric Replication Protection Container Replication Protection Container Mappings",
"description": "This module deploys a Recovery Services Vault (RSV) Replication Protection Container Mapping.\n\n> **Note**: this version of the module only supports the `instanceType: 'A2A'` scenario.",
Expand Down Expand Up @@ -1110,8 +1110,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.26.54.24096",
"templateHash": "13701757307300485900"
"version": "0.26.170.59819",
"templateHash": "11898572463752905132"
},
"name": "Recovery Services Vault Replication Policies",
"description": "This module deploys a Recovery Services Vault Replication Policy for Disaster Recovery scenario.\n\n> **Note**: this version of the module only supports the `instanceType: 'A2A'` scenario.",
Expand Down Expand Up @@ -1235,8 +1235,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.26.54.24096",
"templateHash": "7323008272687100781"
"version": "0.26.170.59819",
"templateHash": "6376319390107718809"
},
"name": "Recovery Services Vault Backup Storage Config",
"description": "This module deploys a Recovery Service Vault Backup Storage Configuration.",
Expand Down Expand Up @@ -1361,8 +1361,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.26.54.24096",
"templateHash": "16058746935194459972"
"version": "0.26.170.59819",
"templateHash": "15446376082900910357"
},
"name": "Recovery Services Vault Protection Container",
"description": "This module deploys a Recovery Services Vault Protection Container.",
Expand Down Expand Up @@ -1500,8 +1500,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.26.54.24096",
"templateHash": "5385249890312845255"
"version": "0.26.170.59819",
"templateHash": "2393851439891433510"
},
"name": "Recovery Service Vaults Protection Container Protected Item",
"description": "This module deploys a Recovery Services Vault Protection Container Protected Item.",
Expand Down Expand Up @@ -1666,8 +1666,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.26.54.24096",
"templateHash": "53495924931537880"
"version": "0.26.170.59819",
"templateHash": "3232253579228240232"
},
"name": "Recovery Services Vault Backup Policies",
"description": "This module deploys a Recovery Services Vault Backup Policy.",
Expand Down Expand Up @@ -1759,8 +1759,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.26.54.24096",
"templateHash": "13689565005288174531"
"version": "0.26.170.59819",
"templateHash": "3057812584997975667"
},
"name": "Recovery Services Vault Backup Config",
"description": "This module deploys a Recovery Services Vault Backup Config.",
Expand Down Expand Up @@ -1926,8 +1926,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.26.54.24096",
"templateHash": "7725737508882142877"
"version": "0.26.170.59819",
"templateHash": "9241144955115347422"
},
"name": "Recovery Services Vault Replication Alert Settings",
"description": "This module deploys a Recovery Services Vault Replication Alert Settings.",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,6 @@ param resourceLocation string = deployment().location
@description('Optional. A short identifier for the kind of deployment. Should be kept short to not run into resource-name length-constraints.')
param serviceShort string = 'rsvmin'

@description('Optional. Enable telemetry via a Globally Unique Identifier (GUID).')
param enableDefaultTelemetry bool = true

@description('Optional. A token to inject into the name of each resource.')
param namePrefix string = '#_namePrefix_#'

Expand All @@ -45,7 +42,6 @@ module testDeployment '../../../main.bicep' = [
name: '${uniqueString(deployment().name, resourceLocation)}-test-${serviceShort}-${iteration}'
params: {
location: resourceLocation
enableTelemetry: enableDefaultTelemetry
name: '${namePrefix}${serviceShort}001'
replicationAlertSettings: {
customEmailAddresses: [
Expand Down
4 changes: 0 additions & 4 deletions avm/res/recovery-services/vault/tests/e2e/dr/main.test.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,6 @@ param resourceLocation string = deployment().location
@description('Optional. A short identifier for the kind of deployment. Should be kept short to not run into resource-name length-constraints.')
param serviceShort string = 'rsvdr'

@description('Optional. Enable telemetry via a Globally Unique Identifier (GUID).')
param enableDefaultTelemetry bool = true

@description('Optional. A token to inject into the name of each resource.')
param namePrefix string = '#_namePrefix_#'

Expand All @@ -45,7 +42,6 @@ module testDeployment '../../../main.bicep' = [
name: '${uniqueString(deployment().name, resourceLocation)}-test-${serviceShort}-${iteration}'
params: {
location: resourceLocation
enableTelemetry: enableDefaultTelemetry
name: rsvName
replicationFabrics: [
{
Expand Down
4 changes: 0 additions & 4 deletions avm/res/recovery-services/vault/tests/e2e/max/main.test.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,6 @@ param resourceLocation string = deployment().location
@description('Optional. A short identifier for the kind of deployment. Should be kept short to not run into resource-name length-constraints.')
param serviceShort string = 'rsvmax'

@description('Optional. Enable telemetry via a Globally Unique Identifier (GUID).')
param enableDefaultTelemetry bool = true

@description('Optional. A token to inject into the name of each resource.')
param namePrefix string = '#_namePrefix_#'

Expand Down Expand Up @@ -69,7 +66,6 @@ module testDeployment '../../../main.bicep' = [
name: '${uniqueString(deployment().name, resourceLocation)}-test-${serviceShort}-${iteration}'
params: {
location: resourceLocation
enableTelemetry: enableDefaultTelemetry
name: '${namePrefix}${serviceShort}001'
backupConfig: {
enhancedSecurityState: 'Disabled'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,6 @@ param resourceLocation string = deployment().location
@description('Optional. A short identifier for the kind of deployment. Should be kept short to not run into resource-name length-constraints.')
param serviceShort string = 'rsvwaf'

@description('Optional. Enable telemetry via a Globally Unique Identifier (GUID).')
param enableDefaultTelemetry bool = true

@description('Optional. A token to inject into the name of each resource.')
param namePrefix string = '#_namePrefix_#'

Expand Down Expand Up @@ -69,7 +66,6 @@ module testDeployment '../../../main.bicep' = [
name: '${uniqueString(deployment().name, resourceLocation)}-test-${serviceShort}-${iteration}'
params: {
location: resourceLocation
enableTelemetry: enableDefaultTelemetry
name: '${namePrefix}${serviceShort}001'
backupConfig: {
enhancedSecurityState: 'Disabled'
Expand Down

0 comments on commit cfbe2e3

Please sign in to comment.