Skip to content

Commit

Permalink
fix: Small test file updates for Load Balancer (#2397)
Browse files Browse the repository at this point in the history
## Description

- Removed explicit dependencies (as they didn't help)
- Changed the zones parameter to the expected int

## Pipeline Reference

<!-- Insert your Pipeline Status Badge below -->

| Pipeline |
| -------- |
|
[![avm.res.network.load-balancer](https://github.com/Azure/bicep-registry-modules/actions/workflows/avm.res.network.load-balancer.yml/badge.svg?branch=users%2Falsehr%2FlbUpdate&event=workflow_dispatch)](https://github.com/Azure/bicep-registry-modules/actions/workflows/avm.res.network.load-balancer.yml)
|

## Type of Change

<!-- Use the checkboxes [x] on the options that are relevant. -->

- [ ] Update to CI Environment or utilities (Non-module affecting
changes)
- [x] Azure Verified Module updates:
- [ ] Bugfix containing backwards-compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`:
- [ ] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [ ] Feature update backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [ ] Breaking changes and I have bumped the MAJOR version in
`version.json`.
  - [ ] Update to documentation
  • Loading branch information
AlexanderSehr authored Jun 15, 2024
1 parent 047fa60 commit e81ccdd
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 38 deletions.
20 changes: 6 additions & 14 deletions avm/res/network/load-balancer/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,7 @@ module loadBalancer 'br/public:avm/res/network/load-balancer:<version>' = {
]
name: 'nlbmin001'
// Non-required parameters
diagnosticSettings: []
location: '<location>'
lock: {}
}
}
```
Expand Down Expand Up @@ -91,14 +89,8 @@ module loadBalancer 'br/public:avm/res/network/load-balancer:<version>' = {
"value": "nlbmin001"
},
// Non-required parameters
"diagnosticSettings": {
"value": []
},
"location": {
"value": "<location>"
},
"lock": {
"value": {}
}
}
}
Expand Down Expand Up @@ -962,9 +954,9 @@ module loadBalancer 'br/public:avm/res/network/load-balancer:<version>' = {
name: 'privateIPConfig1'
subnetId: '<subnetId>'
zones: [
'1'
'2'
'3'
1
2
3
]
}
]
Expand Down Expand Up @@ -1062,9 +1054,9 @@ module loadBalancer 'br/public:avm/res/network/load-balancer:<version>' = {
"name": "privateIPConfig1",
"subnetId": "<subnetId>",
"zones": [
"1",
"2",
"3"
1,
2,
3
]
}
]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -66,18 +66,12 @@ module testDeployment '../../../main.bicep' = [
params: {
name: '${namePrefix}${serviceShort}001'
location: resourceLocation
lock: {}
diagnosticSettings: []
frontendIPConfigurations: [
{
name: 'publicIPConfig1'
publicIPAddressId: nestedDependencies.outputs.publicIPResourceId
}
]
}
dependsOn: [
nestedDependencies
diagnosticDependencies
]
}
]
Original file line number Diff line number Diff line change
Expand Up @@ -192,9 +192,5 @@ module testDeployment '../../../main.bicep' = [
Role: 'DeploymentValidation'
}
}
dependsOn: [
nestedDependencies
diagnosticDependencies
]
}
]
Original file line number Diff line number Diff line change
Expand Up @@ -134,8 +134,5 @@ module testDeployment '../../../main.bicep' = [
Role: 'DeploymentValidation'
}
}
dependsOn: [
nestedDependencies
]
}
]
4 changes: 0 additions & 4 deletions avm/res/network/load-balancer/tests/e2e/max/main.test.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -191,9 +191,5 @@ module testDeployment '../../../main.bicep' = [
Role: 'DeploymentValidation'
}
}
dependsOn: [
nestedDependencies
diagnosticDependencies
]
}
]
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,9 @@ module testDeployment '../../../main.bicep' = [
name: 'privateIPConfig1'
subnetId: nestedDependencies.outputs.subnetResourceId
zones: [
'1'
'2'
'3'
1
2
3
]
}
]
Expand Down Expand Up @@ -147,9 +147,5 @@ module testDeployment '../../../main.bicep' = [
Role: 'DeploymentValidation'
}
}
dependsOn: [
nestedDependencies
diagnosticDependencies
]
}
]

0 comments on commit e81ccdd

Please sign in to comment.