[AVM Module Issue]: Update Microsoft.Search/searchServices API version and allow for additional semanticSearch property #1217
Assignees
Labels
Class: Resource Module 📦
This is a resource module
Needs: Attention 👋
Reply has been added to issue, maintainer to review
Needs: Triage 🔍
Maintainers need to triage still
Type: AVM 🅰️ ✌️ Ⓜ️
This is an AVM related issue
Type: Feature Request ➕
New feature or request
Comments
rodney-almeida
added
Needs: Triage 🔍
microsoft-github-policy-service
bot
added
Needs: Attention 👋
|
@rodney-almeida, thanks for submitting this issue for the A member of the @azure/avm-res-search-searchservice-module-owners-bicep or @azure/avm-res-search-searchservice-module-contributors-bicep team will review it soon! |
11 tasks
AlexanderSehr
pushed a commit
that referenced
this issue
Mar 10, 2024
## Description Updates to `avm/res/search/search-service`: - API version update - added `semanticSearch` property - fixed warning caused by the managed identity implementation Closes #1217 <!-- >Thank you for your contribution ! > Please include a summary of the change and which issue is fixed. > Please also include the context. > List any dependencies that are required for this change. Fixes #123 Fixes #456 Closes #123 Closes #456 --> ## Pipeline Reference <!-- Insert your Pipeline Status Badge below --> | Pipeline | | -------- | | [](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.search.search-service.yml) | ## Type of Change <!-- Use the check-boxes [x] on the options that are relevant. --> - [ ] Update to CI Environment or utlities (Non-module effecting changes) - [x] Azure Verified Module updates: - [ ] Bugfix containing backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in `version.json`: - [ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description. - [ ] The bug was found by the module author, and no one has opened an issue to report it yet. - [x] Feature update backwards compatible feature updates, and I have bumped the MINOR version in `version.json`. - [ ] Breaking changes and I have bumped the MAJOR version in `version.json`. - [ ] Update to documentation ## Checklist - [x] I'm sure there are no other open Pull Requests for the same update/change - [x] I have run `Set-AVMModule` locally to generate the supporting module files. - [x] My corresponding pipelines / checks run clean and green without any errors or warnings <!-- Please keep up to day with the contribution guide at https://aka.ms/avm/contribute/bicep -->
hundredacres
pushed a commit
to hundredacres/bicep-registry-modules
that referenced
this issue
Mar 12, 2024
](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.search.search-service.yml){kind=link}
## Description Updates to `avm/res/search/search-service`: - API version update - added `semanticSearch` property - fixed warning caused by the managed identity implementation Closes Azure#1217 <!-- >Thank you for your contribution ! > Please include a summary of the change and which issue is fixed. > Please also include the context. > List any dependencies that are required for this change. Fixes Azure#123 Fixes Azure#456 Closes Azure#123 Closes Azure#456 --> ## Pipeline Reference <!-- Insert your Pipeline Status Badge below --> | Pipeline | | -------- | | [](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.search.search-service.yml) | ## Type of Change <!-- Use the check-boxes [x] on the options that are relevant. --> - [ ] Update to CI Environment or utlities (Non-module effecting changes) - [x] Azure Verified Module updates: - [ ] Bugfix containing backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in `version.json`: - [ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description. - [ ] The bug was found by the module author, and no one has opened an issue to report it yet. - [x] Feature update backwards compatible feature updates, and I have bumped the MINOR version in `version.json`. - [ ] Breaking changes and I have bumped the MAJOR version in `version.json`. - [ ] Update to documentation ## Checklist - [x] I'm sure there are no other open Pull Requests for the same update/change - [x] I have run `Set-AVMModule` locally to generate the supporting module files. - [x] My corresponding pipelines / checks run clean and green without any errors or warnings <!-- Please keep up to day with the contribution guide at https://aka.ms/avm/contribute/bicep -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Check for previous/existing GitHub issues
Issue Type?
Feature Request
Module Name
avm/res/search/search-service
(Optional) Module Name if not listed above
No response
(Optional) Module Version
No response
Description
Current module using API version 2022-09-01. Newer version available (2023-11-01) which allows for additional properties, such as "semanticSearch"
Thanks
(Optional) Correlation Id
No response
The text was updated successfully, but these errors were encountered: