Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AVM Module Issue]: Allow to disable key metadata write access to follow WAF guidance #1233

Closed
1 task done
bryansan-msft opened this issue Mar 9, 2024 · 1 comment · Fixed by #1407
Closed
1 task done

[AVM Module Issue]: Allow to disable key metadata write access to follow WAF guidance #1233

bryansan-msft opened this issue Mar 9, 2024 · 1 comment · Fixed by #1407
Assignees
@bryansan-msft
Labels
Class: Resource Module 📦 This is a resource module Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Feature Request ➕ New feature or request

Comments

@bryansan-msft
Copy link
Contributor

bryansan-msft commented Mar 9, 2024 •
edited
Loading

Check for previous/existing GitHub issues

  • I have checked for previous/existing GitHub issues

Issue Type?

Feature Request

Module Name

avm/res/document-db/database-account

(Optional) Module Name if not listed above

No response

(Optional) Module Version

No response

Description

Right now the module is getting WAF warnings since we dont support the parameter "disableKeyBasedMetadataWriteAccess"

See here: https://learn.microsoft.com/en-us/azure/cosmos-db/audit-control-plane-logs

(Optional) Correlation Id

No response
@bryansan-msft bryansan-msft added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Mar 9, 2024
@bryansan-msft bryansan-msft self-assigned this Mar 9, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Attention 👋 Reply has been added to issue, maintainer to review Type: Feature Request ➕ New feature or request labels Mar 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 9, 2024

@bryansan-msft, thanks for submitting this issue for the avm/res/document-db/database-account module!

A member of the @azure/avm-res-documentdb-databaseaccount-module-owners-bicep or @azure/avm-res-documentdb-databaseaccount-module-contributors-bicep team will review it soon!

@github-actions github-actions bot added the Class: Resource Module 📦 This is a resource module label Mar 9, 2024
@matebarabas matebarabas removed Needs: Triage 🔍 Maintainers need to triage still Needs: Attention 👋 Reply has been added to issue, maintainer to review labels Mar 12, 2024
@bryansan-msft bryansan-msft mentioned this issue Mar 15, 2024
Closed
1 task
@bryansan-msft bryansan-msft linked a pull request Mar 25, 2024 that will close this issue
feat: avm/res/document-db/database-account public network restricted access and new account level flags #1407
Merged
11 tasks
@bryansan-msft bryansan-msft mentioned this issue Mar 25, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bryansan-msft bryansan-msft

Labels
Class: Resource Module 📦 This is a resource module Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Feature Request ➕ New feature or request
Projects
AVM - Module Issues
Status: Done
Bicep
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: avm/res/document-db/database-account public network restricted access and new account level flags
2 participants
@matebarabas @bryansan-msft