Skip to content

Commit

Permalink
feat: public network restricted access and new account level flags (#…
Browse files Browse the repository at this point in the history
…1407)

## Description
- Added a way to automatically add connection strings and key to a key
vault the consumer specified.
  - Closes #632 
- Added possibility to restrict to IPs, CIDRS and subnets. 
  - Closes #1255 
  - Closes #1370 
- Allow possibility to disable metadata write with access keys. 
  - Closes #1233 
- Allow enablement of multi write/master regions. 
  - Closes #1232
- Removed the use of 'Range' partition key. Impossible to make it work
and there is not any documentation stating that this is even possible to
use/deploy. Not even through the portal or az cli.
  - Closes #1234 
- Changed default kind of database from Parse to GlobalDocumentDb. Parse
is deprecated as per this issue
Azure/azure-cli#16583 (comment)
- Merged tests that can be together without conflicts and significant
increase of deployment duration.
- Added an empty SQL database to most tests to force SQL API accounts to
test common properties.
- Calculate failover location for accounts that only have one region as
the customer currently must repeat the location twice because it was
required.
- Changed test region from eastus to eastasia as it started to have
capacity constraints as well
- In some cases analytical storage ttl cannot be set at all. Not even to
0. So I moved to an union ro remove it completely when it is 0.

PD: @Azure/avm-core-team-technical-bicep Can we make the PSRules less
restrictive or their errors and fixes clearer? I have just wasted 2
hours because I had an error saying my param didn't have a description,
but they did. It turned out it was a missing "." at the end of the
description. I had to dig into the PSRule, take the regex and go to a
regex playground to discover what was happening. Not very developer
friendly I would say

<!--
>Thank you for your contribution !
> Please include a summary of the change and which issue is fixed.
> Please also include the context.
> List any dependencies that are required for this change.

Fixes #123
Fixes #456
Closes #123
Closes #456
-->

## Pipeline Reference

<!-- Insert your Pipeline Status Badge below -->

| Pipeline |
| -------- |
|
[![avm.res.document-db.database-account](https://github.com/bryansan-msft/fork-bicep-registry-modules/actions/workflows/avm.res.document-db.database-account.yml/badge.svg)](https://github.com/bryansan-msft/fork-bicep-registry-modules/actions/workflows/avm.res.document-db.database-account.yml)
|

## Type of Change

<!-- Use the check-boxes [x] on the options that are relevant. -->

- [ ] Update to CI Environment or utlities (Non-module effecting
changes)
- [ ] Azure Verified Module updates:
- [ ] Bugfix containing backwards compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`:
- [x] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [x] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [x] Feature update backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [ ] Breaking changes and I have bumped the MAJOR version in
`version.json`.
  - [x] Update to documentation

## Checklist

- [x] I'm sure there are no other open Pull Requests for the same
update/change
- [x] I have run `Set-AVMModule` locally to generate the supporting
module files.
- [x] My corresponding pipelines / checks run clean and green without
any errors or warnings

<!-- Please keep up to day with the contribution guide at
https://aka.ms/avm/contribute/bicep -->
  • Loading branch information
bryansan-msft authored Mar 26, 2024
1 parent 0bb60e9 commit c2f6250
Show file tree
Hide file tree
Showing 34 changed files with 1,497 additions and 1,508 deletions.
1,429 changes: 625 additions & 804 deletions avm/res/document-db/database-account/README.md

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.25.53.49325",
"templateHash": "4078462189838201163"
"version": "0.26.54.24096",
"templateHash": "2823004405398378621"
},
"name": "DocumentDB Database Accounts Gremlin Databases Graphs",
"description": "This module deploys a DocumentDB Database Accounts Gremlin Database Graph.",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.25.53.49325",
"templateHash": "5227237801347888732"
"version": "0.26.54.24096",
"templateHash": "13414524346849431368"
},
"name": "DocumentDB Database Account Gremlin Databases",
"description": "This module deploys a Gremlin Database within a CosmosDB Account.",
Expand Down Expand Up @@ -109,8 +109,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.25.53.49325",
"templateHash": "4078462189838201163"
"version": "0.26.54.24096",
"templateHash": "2823004405398378621"
},
"name": "DocumentDB Database Accounts Gremlin Databases Graphs",
"description": "This module deploys a DocumentDB Database Accounts Gremlin Database Graph.",
Expand Down
228 changes: 177 additions & 51 deletions avm/res/document-db/database-account/main.bicep

Large diffs are not rendered by default.

Loading

0 comments on commit c2f6250

Please sign in to comment.