[AVM Module Issue]: Improve (fix) naming on Virtual Wan Hub Connections

[noopman]

Check for previous/existing GitHub issues

• I have checked for previous/existing GitHub issues

Issue Type?

Feature Request

Module Name

avm/ptn/lz/sub-vending

(Optional) Module Version

No response

Description

The naming of Virtual Wan Hub Connections is based on a guid. It looks incredibly ugly in the list of connections. Real world example: vhc-48b529d4-e9c0-5a89-87d8-a413512e103f

I propose:

• Make much better names for the connection using the vnet name as part of the connection name by default!
• Consider allowing the connection name to be an optional parameter!

Here is the exact location in code where the virtualWanHubConnectionName is set.

var virtualWanHubConnectionName = 'vhc-${guid(virtualHubResourceIdChecked, virtualNetworkName, virtualNetworkResourceGroupName, virtualNetworkLocation, subscriptionId)}'

Instead we could have 'cn' for connection and the name could be as simple as this:

var virtualWanHubConnectionName = 'cn-${virtualNetworkName}'

(Optional) Correlation Id

No response

[microsoft-github-policy-service]

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

[avm-team-linter]

@noopman, thanks for submitting this issue for the avm/ptn/lz/sub-vending module!

Important

A member of the @Azure/avm-ptn-lz-subvending-module-owners-bicep or @Azure/avm-ptn-lz-subvending-module-contributors-bicep team will review it soon!

[sebassem]

Thanks for submitting this issue, we are looking into how to better handle this

[microsoft-github-policy-service]

Warning

Tagging the AVM Core Team (@Azure/avm-core-team-technical-bicep) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly.

Tip

• To prevent further actions to take effect, the "Status: Response Overdue 🚩" label must be removed, once this issue has been responded to.
• To avoid this rule being (re)triggered, the ""Needs: Triage 🔍" label must be removed as part of the triage process (when the issue is first responded to)!