Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New Module avm/res/signal-r-service/signal-r #1109

Merged
merged 21 commits into from
Mar 11, 2024

Conversation

krbar
Copy link
Contributor

@krbar krbar commented Mar 1, 2024

Description

New Module avm/res/signal-r-service/signal-r, migrated from CARML.

Adding a new module

  • A proposal has been submitted and approved.
  • I have included "Closes #{module_proposal_issue_number}" in the PR description.
  • I have run brm validate locally to verify the module files.
  • I have run deployment tests locally to ensure the module is deployable.

Pipeline references

Pipeline
avm.res.signal-r-service.signal-r

@krbar krbar self-assigned this Mar 1, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Mar 1, 2024
@krbar krbar marked this pull request as ready for review March 2, 2024 09:23
@krbar krbar requested review from a team as code owners March 2, 2024 09:23
Copy link
Contributor

@segraef segraef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added some comments to what @AlexanderSehr already marked

@krbar krbar marked this pull request as draft March 4, 2024 22:41
@krbar krbar marked this pull request as ready for review March 8, 2024 22:52
@krbar krbar enabled auto-merge (squash) March 11, 2024 13:16
@krbar krbar merged commit 280e596 into Azure:main Mar 11, 2024
9 checks passed
@krbar krbar deleted the users/krbar/signalRModule branch March 11, 2024 19:45
hundredacres pushed a commit to hundredacres/bicep-registry-modules that referenced this pull request Mar 12, 2024
## Description

New Module `avm/res/signal-r-service/signal-r`, migrated from CARML.

## Adding a new module

<!--Run through the checklist if your PR adds a new module.-->

- [x] A proposal has been submitted and approved.
- [ ] I have included "Closes #{module_proposal_issue_number}" in the PR
description.
- [ ] I have run `brm validate` locally to verify the module files.
- [x] I have run deployment tests locally to ensure the module is
deployable.

## Pipeline references

| Pipeline |
| - |
|
[![avm.res.signal-r-service.signal-r](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.signal-r-service.signal-r.yml/badge.svg?branch=users%2Fkrbar%2FsignalRModule)](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.signal-r-service.signal-r.yml)
|
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants