Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New Module avm/res/signal-r-service/web-pub-sub #1219

Merged
merged 19 commits into from
Mar 10, 2024

Conversation

krbar
Copy link
Contributor

@krbar krbar commented Mar 8, 2024

Description

New Module avm/res/signal-r-service/web-pub-sub, migrated from CARML.

Adding a new module

  • A proposal has been submitted and approved.
  • I have included "Closes #{module_proposal_issue_number}" in the PR description.
  • I have run brm validate locally to verify the module files.
  • I have run deployment tests locally to ensure the module is deployable.

Pipeline references

Pipeline
avm.res.signal-r-service.web-pub-sub

@krbar krbar self-assigned this Mar 8, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Mar 8, 2024
@krbar krbar marked this pull request as ready for review March 8, 2024 23:50
@krbar krbar requested review from a team as code owners March 8, 2024 23:50
@AlexanderSehr AlexanderSehr added Class: Resource Module 📦 This is a resource module and removed Needs: Triage 🔍 Maintainers need to triage still labels Mar 10, 2024
@AlexanderSehr AlexanderSehr merged commit 3bb3599 into Azure:main Mar 10, 2024
9 checks passed
@krbar krbar deleted the users/krbar/webPubSubModule branch March 11, 2024 19:45
hundredacres pushed a commit to hundredacres/bicep-registry-modules that referenced this pull request Mar 12, 2024
## Description

New Module `avm/res/signal-r-service/web-pub-sub`, migrated from CARML.

## Adding a new module

<!--Run through the checklist if your PR adds a new module.-->

- [x] A proposal has been submitted and approved.
- [ ] I have included "Closes #{module_proposal_issue_number}" in the PR
description.
- [ ] I have run `brm validate` locally to verify the module files.
- [x] I have run deployment tests locally to ensure the module is
deployable.

## Pipeline references

| Pipeline |
| - |
|
[![avm.res.signal-r-service.web-pub-sub](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.signal-r-service.web-pub-sub.yml/badge.svg?branch=users%2Fkrbar%2FwebPubSubModule)](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.signal-r-service.web-pub-sub.yml)
|

---------

Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Resource Module 📦 This is a resource module Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants