Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed Bicep warning caused by the identity type #1238

Merged
merged 9 commits into from
Mar 25, 2024

Conversation

krbar
Copy link
Contributor

@krbar krbar commented Mar 10, 2024

Description

Fixed BCP321 warning caused by the identity variable in multiple modules.

image

Pipeline Reference

Pipeline
avm.res.api-management.service
avm.res.app.container-app
avm.res.batch.batch-account
avm.res.cache.redis
avm.res.data-factory.factory
avm.res.databricks.access-connector
avm.res.db-for-postgre-sql.flexible-server
Error related to the WAF Reliability, not to this PR. Both static and deployment validations work fine.
avm.res.logic.workflow
avm.res.net-app.net-app-account
avm.res.storage.storage-account

Type of Change

  • Update to CI Environment or utlities (Non-module effecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

@krbar krbar self-assigned this Mar 10, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Mar 10, 2024
@krbar krbar changed the title Users/krbar/identity warning fix fix: fixed Bicep warning caused by the identity type Mar 10, 2024
@krbar krbar marked this pull request as ready for review March 11, 2024 13:50
@krbar krbar requested review from a team as code owners March 11, 2024 13:50
JPEasier
JPEasier previously approved these changes Mar 12, 2024
avm/res/api-management/service/main.bicep Show resolved Hide resolved
segraef
segraef previously approved these changes Mar 13, 2024
Copy link
Contributor

@segraef segraef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@matebarabas matebarabas added Type: Hygiene 🧹 things related to testing, issue triage etc. and removed Needs: Triage 🔍 Maintainers need to triage still labels Mar 22, 2024
AlexanderSehr
AlexanderSehr previously approved these changes Mar 25, 2024
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) March 25, 2024 19:59
@krbar krbar dismissed stale reviews from AlexanderSehr, segraef, and JPEasier via 2b1e3c5 March 25, 2024 22:28

Note

The "Type: AVM 🅰️ ✌️ Ⓜ️" label was added as per ITA08BCP.

@AlexanderSehr AlexanderSehr merged commit 0bb60e9 into Azure:main Mar 25, 2024
11 checks passed
@krbar krbar deleted the users/krbar/identityWarningFix branch March 29, 2024 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Hygiene 🧹 things related to testing, issue triage etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants