Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: WAF reliability and static validation in avm/res/web/site #1427

Merged
merged 8 commits into from
Apr 17, 2024

Conversation

krbar
Copy link
Contributor

@krbar krbar commented Mar 26, 2024

Description

  • added PSRule exceptions for defaults tests
  • removed optional parameters from defaults tests
  • re-generated readme due to static validation errors

fixes #1378
fixes #1510
fixes #1592

Pipeline Reference

Pipeline
avm.res.web.site

Type of Change

  • Update to CI Environment or utlities (Non-module effecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

@krbar krbar self-assigned this Mar 26, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Mar 26, 2024
@krbar krbar marked this pull request as ready for review March 26, 2024 20:58
@krbar krbar requested review from a team as code owners March 26, 2024 20:58
@krbar krbar changed the title fix.: WAF reliability and static validation in avm/res/web/site fix: WAF reliability and static validation in avm/res/web/site Mar 26, 2024
@matebarabas matebarabas added Class: Resource Module 📦 This is a resource module and removed Needs: Triage 🔍 Maintainers need to triage still labels Mar 26, 2024
@eriqua eriqua merged commit 025b862 into Azure:main Apr 17, 2024
6 checks passed
sebassem added a commit to sebassem/bicep-registry-modules that referenced this pull request Apr 17, 2024
…mit messages in this repository:

1. added readme
2. feat: Added UDTs for disks and ability to give a custom name to a disk - `avm/res/compute/virtual-machine` (Azure#1517)
3. Merge branch 'Azure:main' into avm-ptn-alz-sub-vending
4. fix: Dnsrule bug for virtual Network link name (Azure#1538)
5. fix: prevent updating the workspace repository configuration whenever no value is provided, so an existing configuration is not overwritten. (Azure#1680)
6. fix: WAF reliability and static validation in `avm/res/web/site`  (Azure#1427)
7. fix: Update for default WAF-alignment - `avm/res/cache/redis` (Azure#1621)
8. Merge branch 'Azure:main' into avm-ptn-alz-sub-vending
9. fix: pwsh publish module index (Azure#1683)
10. feat: Added UDTs for disks and ability to give a custom name to a disk - `avm/res/compute/virtual-machine` (Azure#1517)
segraef pushed a commit to segraef/bicep-registry-modules that referenced this pull request Apr 17, 2024
…re#1427)

## Description

- added PSRule exceptions for `defaults` tests
- removed optional parameters from `defaults` tests
- re-generated readme due to static validation errors

fixes Azure#1378 
fixes Azure#1510 
fixes Azure#1592 

<!--
>Thank you for your contribution !
> Please include a summary of the change and which issue is fixed.
> Please also include the context.
> List any dependencies that are required for this change.

Fixes Azure#123
Fixes Azure#456
Closes Azure#123
Closes Azure#456
-->

## Pipeline Reference

<!-- Insert your Pipeline Status Badge below -->

| Pipeline |
| -------- |
|
[![avm.res.web.site](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.web.site.yml/badge.svg?branch=users%2Fkrbar%2FwebSiteFix)](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.web.site.yml)
|

## Type of Change

<!-- Use the check-boxes [x] on the options that are relevant. -->

- [ ] Update to CI Environment or utlities (Non-module effecting
changes)
- [x] Azure Verified Module updates:
- [x] Bugfix containing backwards compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`:
- [x] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [ ] Feature update backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [ ] Breaking changes and I have bumped the MAJOR version in
`version.json`.
  - [ ] Update to documentation

## Checklist

- [x] I'm sure there are no other open Pull Requests for the same
update/change
- [x] I have run `Set-AVMModule` locally to generate the supporting
module files.
- [x] My corresponding pipelines / checks run clean and green without
any errors or warnings

<!-- Please keep up to day with the contribution guide at
https://aka.ms/avm/contribute/bicep -->
donk-msft pushed a commit to donk-msft/bicep-registry-modules that referenced this pull request Apr 29, 2024
…re#1427)

## Description

- added PSRule exceptions for `defaults` tests
- removed optional parameters from `defaults` tests
- re-generated readme due to static validation errors

fixes Azure#1378 
fixes Azure#1510 
fixes Azure#1592 

<!--
>Thank you for your contribution !
> Please include a summary of the change and which issue is fixed.
> Please also include the context.
> List any dependencies that are required for this change.

Fixes Azure#123
Fixes Azure#456
Closes Azure#123
Closes Azure#456
-->

## Pipeline Reference

<!-- Insert your Pipeline Status Badge below -->

| Pipeline |
| -------- |
|
[![avm.res.web.site](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.web.site.yml/badge.svg?branch=users%2Fkrbar%2FwebSiteFix)](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.web.site.yml)
|

## Type of Change

<!-- Use the check-boxes [x] on the options that are relevant. -->

- [ ] Update to CI Environment or utlities (Non-module effecting
changes)
- [x] Azure Verified Module updates:
- [x] Bugfix containing backwards compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`:
- [x] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [ ] Feature update backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [ ] Breaking changes and I have bumped the MAJOR version in
`version.json`.
  - [ ] Update to documentation

## Checklist

- [x] I'm sure there are no other open Pull Requests for the same
update/change
- [x] I have run `Set-AVMModule` locally to generate the supporting
module files.
- [x] My corresponding pipelines / checks run clean and green without
any errors or warnings

<!-- Please keep up to day with the contribution guide at
https://aka.ms/avm/contribute/bicep -->
@krbar krbar deleted the users/krbar/webSiteFix branch May 14, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Resource Module 📦 This is a resource module Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Failed pipeline] avm.res.web.site [Failed pipeline] avm.res.web.site [Failed pipeline] avm.res.web.site
5 participants