Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Added -Culture 'en-US' to all Sort-Object operations #1976

Merged
merged 160 commits into from
May 20, 2024

Conversation

AlexanderSehr
Copy link
Contributor

@AlexanderSehr AlexanderSehr commented May 20, 2024

Description

  • Added -Culture 'en-US' to all Sort-Object operations to mitigate issues some contributors with a different configured culture have
  • Re-ran the generation for all files (no changes)

Related to Azure/ResourceModules#3722, but needs to be fixed there seperately

Type of Change

  • Update to CI Environment or utlities (Non-module effecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

@AlexanderSehr AlexanderSehr requested a review from a team as a code owner May 20, 2024 08:06

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

Note

This label was added as per ITA06.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label May 20, 2024
@AlexanderSehr AlexanderSehr linked an issue May 20, 2024 that may be closed by this pull request
1 task
@AlexanderSehr AlexanderSehr self-assigned this May 20, 2024
@AlexanderSehr AlexanderSehr added Type: Bug 🐛 Something isn't working Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue and removed Needs: Triage 🔍 Maintainers need to triage still labels May 20, 2024
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) May 20, 2024 08:07
@AlexanderSehr AlexanderSehr merged commit bc8d57b into Azure:main May 20, 2024
14 checks passed
@AlexanderSehr AlexanderSehr deleted the users/alsehr/1930_sortUS branch May 20, 2024 13:52
hundredacres pushed a commit to hundredacres/bicep-registry-modules that referenced this pull request Jun 19, 2024
…1976)

## Description

- Added `-Culture 'en-US'` to all `Sort-Object` operations to mitigate
issues some contributors with a different configured culture have
- Re-ran the generation for all files (no changes)

Related to Azure/ResourceModules#3722, but
needs to be fixed there seperately

## Type of Change

<!-- Use the check-boxes [x] on the options that are relevant. -->

- [x] Update to CI Environment or utlities (Non-module effecting
changes)
- [ ] Azure Verified Module updates:
- [ ] Bugfix containing backwards compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`:
- [ ] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [ ] Feature update backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [ ] Breaking changes and I have bumped the MAJOR version in
`version.json`.
  - [ ] Update to documentation

---------

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AVM Module Issue]: Set-AVMModule updates README.md with wrong sort order
2 participants