Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(new): Automation Account Runbook #202

Closed
wants to merge 38 commits into from

Conversation

Gordonby
Copy link
Contributor

@Gordonby Gordonby commented Nov 17, 2022

Description

This contribution Closes #199

This module does use experimental features: userDefinedTypes

Adding a new module

  • A proposal has been submitted and approved.
  • I have included "Closes #{module_proposal_issue_number}" in the PR description.
  • I have run brm validate locally to verify the module files.
  • I have run deployment tests locally to ensure the module is deployable.

Gordonby added 4 commits November 17, 2022 11:27
Signed-off-by: Gordonby <gordon.byers@microsoft.com>
Signed-off-by: Gordonby <gordon.byers@microsoft.com>
Signed-off-by: Gordonby <gordon.byers@microsoft.com>
Signed-off-by: Gordonby <gordon.byers@microsoft.com>
@Gordonby Gordonby requested a review from dciborow November 17, 2022 15:49
Gordonby added 2 commits November 20, 2022 19:31
Signed-off-by: Gordonby <gordon.byers@microsoft.com>
Signed-off-by: Gordonby <gordon.byers@microsoft.com>
@Gordonby
Copy link
Contributor Author

Gordonby commented Nov 20, 2022

I've added UserDefinedTypes to this bicep module @alex-frankel - which really helps with the flexibility/maturity of the use case.
However we should hold off on this PR progressing until after the next bicep release.

@alex-frankel
Copy link

I don't think we should use user-defined types in a public modules until the feature is enabled by default. Otherwise, this module will only work if the preview flag is enabled. Thoughts?

Of course, it's great that you are trying the feature out and glad it is improving usability :)

@Gordonby
Copy link
Contributor Author

Gordonby commented Nov 21, 2022

I don't think we should use user-defined types in a public modules until the feature is enabled by default. Otherwise, this module will only work if the preview flag is enabled. Thoughts?

Agreed, public modules should be easy to adopt 👍

Gordonby added 4 commits November 30, 2022 21:34
Signed-off-by: Gordonby <gordon.byers@microsoft.com>
Signed-off-by: Gordonby <gordon.byers@microsoft.com>
@Gordonby Gordonby changed the title New Module: Automation Account Runbook feat: Automation Account Runbook Jun 5, 2023
@Gordonby Gordonby marked this pull request as ready for review June 5, 2023 15:49
@Gordonby Gordonby marked this pull request as draft June 5, 2023 15:58
@Gordonby
Copy link
Contributor Author

Gordonby commented Jun 5, 2023

Made changes for compatibility to 0.17.1

@Gordonby Gordonby marked this pull request as ready for review June 5, 2023 18:20
@Gordonby
Copy link
Contributor Author

Gordonby commented Jun 5, 2023

Probably need to keep this one on hold until #372 is complete.
If merged, would be used in AKS Construction. Azure/AKS-Construction#406

@Gordonby Gordonby requested a review from alex-frankel June 5, 2023 19:02
@Gordonby Gordonby changed the title feat: Automation Account Runbook feat(new): Automation Account Runbook Jun 6, 2023
@Gordonby
Copy link
Contributor Author

Gordonby commented Jul 5, 2023

@microsoft-github-policy-service agree

@Gordonby
Copy link
Contributor Author

Gordonby commented Jul 8, 2023

@dciborow - As we're taking module that use Custom Types now (eg. The CosmosDb one). I would consider this module ready for review/merge.

@Gordonby
Copy link
Contributor Author

Gordonby commented Aug 9, 2023

@dciborow Have you had a chance to review?

@Gordonby Gordonby requested review from a team as code owners January 5, 2024 09:16
@ChrisSidebotham
Copy link
Contributor

Closing as stale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Module Proposal]: Automation Runbook
3 participants