Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CI - Fixed moduleIndex implementation for scheduled runs #2863

Merged
merged 3 commits into from
Jul 28, 2024

Conversation

AlexanderSehr
Copy link
Contributor

Description

  • Added code we use in the module pipelines to read workflow inputs and rely on that task as opposed to direct runtime parameter references (which are only available during workflow_dispatch)

Condition tests
With tickbox
image

Without tickbox
image

Pipeline Reference

Pipeline
.Platform - Publish [moduleIndex.json]

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

@AlexanderSehr AlexanderSehr requested review from a team as code owners July 28, 2024 08:28
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label Jul 28, 2024

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

Important

If this is a module-related PR, being submitted by the sole owner of the module, the AVM core team must review and approve it (as module owners can't approve their own PRs).

To indicate this PR needs the core team''s attention, apply the "Needs: Core Team 🧞" label!

The core team will only review and approve PRs that have this label applied!

@AlexanderSehr AlexanderSehr added Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Bug 🐛 Something isn't working Type: CI 🚀 This issue is related to the AVM CI and removed Needs: Triage 🔍 Maintainers need to triage still labels Jul 28, 2024
@AlexanderSehr AlexanderSehr self-assigned this Jul 28, 2024
@AlexanderSehr AlexanderSehr added the Needs: Core Team 🧞 This item needs the AVM Core Team to review it label Jul 28, 2024
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) July 28, 2024 08:28
@AlexanderSehr AlexanderSehr merged commit 2a48a03 into main Jul 28, 2024
16 checks passed
@AlexanderSehr AlexanderSehr deleted the users/alsehr/fixIndexPublish branch July 28, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Core Team 🧞 This item needs the AVM Core Team to review it Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Bug 🐛 Something isn't working Type: CI 🚀 This issue is related to the AVM CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants