Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Avm ptn acalza hostingenvironment - avm/ptn/aca-lza/hosting-environment #2969

Merged
merged 104 commits into from
Aug 7, 2024

Conversation

kpantos
Copy link
Member

@kpantos kpantos commented Aug 2, 2024

Description

This Azure Container Apps pattern module represents an Azure Container Apps deployment aligned with the cloud adoption framework implementing industry proven practices, such as those presented in Azure landing zones guidance in the Cloud Adoption Framework, owned and operated by a workload team. This avm pattern module provides a production ready reference implementation of a containerized apps hosting environment with Azure Container Apps.

As part of this pattern module the following services will be deployed:

A resource group (Spoke) to deploy all resources
A VNet with 4 subnets hosting the services
An internal Azure container apps environment
An Azure key vault exposed through a private endpoint
An Azure Container Registry reachable through a private endpoint
Azure Application Gateway or Azure Front Door to expose applications hosted at Azure Container Apps
A Virtual Machine serving as a jump box for the locked down environment

Pipeline Reference

Pipeline
avm.ptn.aca-lza.hosting-environment

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • New pattern module implementation
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

kpantos and others added 30 commits June 19, 2024 00:38
…arting with a "Category" prefix like "Required.
kpantos and others added 12 commits August 4, 2024 20:12
….bicep

Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
….bicep

Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
…st.bicep

Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
…est.bicep

Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
…est.bicep

Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
….test.bicep

Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
…y/deploy.app-gateway.bicep

Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
@matebarabas matebarabas changed the title feat: Avm ptn acalza hostingenvironment feat: Avm ptn acalza hostingenvironment - avm/ptn/aca-lza/hosting-environment Aug 6, 2024
@matebarabas matebarabas added Class: Pattern Module 📦 This is a pattern module and removed Needs: Triage 🔍 Maintainers need to triage still labels Aug 6, 2024
@kpantos
Copy link
Member Author

kpantos commented Aug 7, 2024

@AlexanderSehr all of the suggestions have been implemented. Can you please have a look and complete your review?

@AlexanderSehr
Copy link
Contributor

@AlexanderSehr all of the suggestions have been implemented. Can you please have a look and complete your review?

Hey @kpantos,
will do. One small ask for future reviews if you don't mind: Please only resolve comments that are marked as suggestions as otherwise a re-review is a bit tedious as I need to expand each comment to see what I have to re-review and what not 😉

@AlexanderSehr AlexanderSehr merged commit 0440109 into Azure:main Aug 7, 2024
4 checks passed
@matebarabas
Copy link
Contributor

@kpantos, congrats for publishing this module!

I'd have a few comments/asks:

  • this PR hasn't been linked with the related module proposal
  • the successful publication of this modules hasn't been communicated back on the module proposal, hence the index hasn't been updated, and hence one of our bots have opened the following issue

I'll update the index soon, and will help you with all the closing tasks, but would like to ask you to please do the above steps with your next module(s)!

Many thanks and congrats again for this publication!

@matebarabas
Copy link
Contributor

Index updated; related issues closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Pattern Module 📦 This is a pattern module Needs: Core Team 🧞 This item needs the AVM Core Team to review it Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants