fix: Add support for forced tunneling #3373
Conversation
This PR fixes the issue, that failed workflows were not assigned to the correct owner
## Description <!-- >Thank you for your contribution ! > Please include a summary of the change and which issue is fixed. > Please also include the context. > List any dependencies that are required for this change. Fixes Azure#1735 Closes Azure#1735 --> ## Pipeline Reference <!-- Insert your Pipeline Status Badge below --> | Pipeline | | -------- | | [](https://github.com/JFolberth/bicep-registry-modules/actions/workflows/avm.res.insights.webtest.yml) | ## Type of Change <!-- Use the check-boxes [x] on the options that are relevant. --> - [ ] Update to CI Environment or utlities (Non-module effecting changes) - [ ] Azure Verified Module updates: - [ ] Bugfix containing backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in `version.json`: - [ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description. - [ ] The bug was found by the module author, and no one has opened an issue to report it yet. - [ ] Feature update backwards compatible feature updates, and I have bumped the MINOR version in `version.json`. - [ ] Breaking changes and I have bumped the MAJOR version in `version.json`. - [x] Update to documentation ## Checklist - [x] I'm sure there are no other open Pull Requests for the same update/change - [x] I have run `Set-AVMModule` locally to generate the supporting module files. - [x] My corresponding pipelines / checks run clean and green without any errors or warnings <!-- Please keep up to day with the contribution guide at https://aka.ms/avm/contribute/bicep -->
microsoft-github-policy-service
bot
added
the
Needs: Triage 🔍
|
Important The "Needs: Triage 🔍" label must be removed once the triage process is complete! Tip For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation. |
microsoft-github-policy-service
bot
added
the
Type: AVM 🅰️ ✌️ Ⓜ️
|
Important If this is a module-related PR, being submitted by the sole owner of the module, the AVM core team must review and approve it (as module owners can't approve their own PRs). To indicate this PR needs the core team''s attention, apply the "Needs: Core Team 🧞" label! The core team will only review and approve PRs that have this label applied! |
avm-team-linter
bot
added
the
Needs: Module Owner 📣
|
@hundredacres Please reach out if any support is needed. |
|
@ReneHezser / @Azure/avm-res-network-azurefirewall-module-owners-bicep can I get a review here? |
Hey @hundredacres, sorry my bad. I saw that @rahalan is part of the owner team and hence assumed he's a co-owner who'd do the review. After checking the AVM page, I can see that's not the case. I'd recommend to probably 'fix' that to avoid the confusion in the future 😉 |
avm/res/network/azure-firewall/tests/e2e/tunneling/main.test.bicep
Outdated
Show resolved
Hide resolved
](https://github.com/JFolberth/bicep-registry-modules/actions/workflows/avm.res.insights.webtest.yml){kind=link}
|
Great work @hundredacres, off we go 🌊 |
Description
Adds param to enable forcedTunneling, which adds a managementIPAddress.
Fixes #3368
Closes #3368
Pipeline Reference
Type of Change
version.json:version.json.version.json.Checklist
Set-AVMModulelocally to generate the supporting module files.