fix: Update parameters to implement non-AAD integrated clusters in Kubernetes #3828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avm-team-linter
bot
added
the
Needs: Module Owner 📣
microsoft-github-policy-service
bot
added
Needs: Triage 🔍
update main.json update main.json update main.json update main.json update main.json
Menghua1
force-pushed
the
fix/add-aad-profile-conditional
branch
from
113393b to
71933fd
Compare
|
@AlexanderSehr Could you please review this PR? |
Hey @Menghua1, Also, there is a very blocking PR here. Without that being resolved, we cannot move forward as this PR. If merged regardless, it will fail the deployment tests in AVM and hence never make it to the publish stage. |
Menghua1
force-pushed
the
fix/add-aad-profile-conditional
branch
from
4adfaac to
063c8c5
Compare
Menghua1
changed the title
enableAad parameter to conditionally configure AAD profile in Kubernetes
JPEasier
reviewed
Nov 29, 2024
avm/res/container-service/managed-cluster/tests/e2e/non-aad-cluster/main.test.bicep
Outdated
Show resolved
Hide resolved
JPEasier
added
the
Needs: Author Feedback 👂
Menghua1
force-pushed
the
fix/add-aad-profile-conditional
branch
from
198cca6 to
4253e3e
Compare
|
@AlexanderSehr If there are no issues with this PR review, please help merge this PR. Thanks a lot. |
microsoft-github-policy-service
bot
added
Needs: Attention 👋
Not from my end, but I'll leave the final review to the module's owner @JPEasier :) |
|
@AlexanderSehr Is #3646 no longer blocking PR? |
|
@JPEasier Could you please review this PR? If there is no problem, please merge them. Thank a lot. |
true, true. Thanks for pointing this out @ilhaan |
|
@JPEasier can you help with merging this PR? cc @matebarabas @jongio |
ilhaan
approved these changes
Dec 11, 2024
This was referenced Dec 12, 2024
AlexanderSehr
pushed a commit
that referenced
this pull request
Jan 7, 2025
…n Kubernetes (#3928) ## Description Based on PR #3828 update to `avm/res/container-service/managed-cluster`, add `aadProfile` parameter to control AAD integration. <!-- >Thank you for your contribution ! > Please include a summary of the change and which issue is fixed. > Please also include the context. > List any dependencies that are required for this change. Fixes #123 Fixes #456 Closes #123 Closes #456 --> ## Pipeline Reference <!-- Insert your Pipeline Status Badge below --> | Pipeline | | -------- | | [](https://github.com/Menghua1/bicep-registry-modules/actions/workflows/avm.ptn.azd.aks.yml) | ## Type of Change <!-- Use the checkboxes [x] on the options that are relevant. --> - [ ] Update to CI Environment or utilities (Non-module affecting changes) - [x] Azure Verified Module updates: - [ ] Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in `version.json`: - [ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description. - [ ] The bug was found by the module author, and no one has opened an issue to report it yet. - [ ] Feature update backwards compatible feature updates, and I have bumped the MINOR version in `version.json`. - [ ] Breaking changes and I have bumped the MAJOR version in `version.json`. - [ ] Update to documentation ## Checklist - [x] I'm sure there are no other open Pull Requests for the same update/change - [x] I have run `Set-AVMModule` locally to generate the supporting module files. - [x] My corresponding pipelines / checks run clean and green without any errors or warnings <!-- Please keep up to date with the contribution guide at https://aka.ms/avm/contribute/bicep --> @rajeshkamal5050 for notification.
](https://github.com/Menghua1/bicep-registry-modules/actions/workflows/avm.ptn.azd.aks.yml){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a conditional check for
aadProfileconfiguration in Kubernetes cluster settings. Adds a user-defined type for theaadProfileparameter, and when theaadProfileparameter is empty, it disables AAD (Azure Active Directory). Ensures that AAD integration is completely skipped when not needed, optimizing resource usage and configuration complexity.Requested by the AZD team: Azure/Azure-Verified-Modules#261, to ensure consistency with the functionality implemented in the aks-managed-cluster.bicep file located in infra/core.
Pipeline Reference
Type of Change
version.json:version.json.version.json.Checklist
Set-AVMModulelocally to generate the supporting module files.@rajeshkamal5050 for notification.