Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new module network/vpn-gateway #750

Merged
merged 11 commits into from
Jan 2, 2024
Merged

feat: new module network/vpn-gateway #750

merged 11 commits into from
Jan 2, 2024

Conversation

fabmas
Copy link
Member

@fabmas fabmas commented Dec 27, 2023

Description

New network/virtual-network-gateway module migrated from CARML to AVM

avm.res.network.vpn-gateway

@fabmas fabmas requested review from a team as code owners December 27, 2023 15:32
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Dec 27, 2023
@eriqua eriqua added Class: Resource Module 📦 This is a resource module and removed Needs: Triage 🔍 Maintainers need to triage still labels Dec 27, 2023
fabmas and others added 4 commits December 28, 2023 17:36
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
Copy link
Contributor

@AlexanderSehr AlexanderSehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to also run the Set-AVMModule utility after applying all changes. Ideally, also re-run the pipeline.

Copy link
Contributor

@AlexanderSehr AlexanderSehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @fabmas , the PR looks good to me. However, please note that there is one small conflict that needs resolving first.

@fabmas fabmas enabled auto-merge (squash) January 2, 2024 09:54
@fabmas fabmas merged commit 77913e2 into Azure:main Jan 2, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Resource Module 📦 This is a resource module Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants