Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config Outlook as a Channel for Bot Service #5085

Closed
MuyangAmigo opened this issue Nov 5, 2021 · 12 comments
Closed

Config Outlook as a Channel for Bot Service #5085

MuyangAmigo opened this issue Nov 5, 2021 · 12 comments

Comments

@MuyangAmigo
Copy link

MuyangAmigo commented Nov 5, 2021

Is your feature request related to a problem? Please describe.
I want to develop a bot that also runs in the Outlook, right I can config the Azure Bot Service via Portal to include Outlook as well, but it's not possible to do this via Bicep. (Which my Bot Service and Configuration is provisioned using Bicep)
image

Describe the solution you'd like
I would like to config my bot service with outlook as an channel in similar way to config Teams.
image

@MuyangAmigo MuyangAmigo added the enhancement New feature or request label Nov 5, 2021
@ghost ghost added the Needs: Triage 🔍 label Nov 5, 2021
@alex-frankel
Copy link
Collaborator

My guess is the channelName name property is missing this allowed value, but it should still be possible to use that value if we can figure out what it is. I created one quickly, and from resources.azure.com, it looks like it is simply called outlook

image

So if you specify channelName: 'outlook', I would expect this to work.

@MuyangAmigo
Copy link
Author

Hi, kindly follow up on this - is there any update on this issue? Thanks!

@alex-frankel
Copy link
Collaborator

Did you try using channelName: 'outlook' and did that work as expected?

I'm not sure when the type information will get updated for this as it is dependent on the RP team providing it, but it should not block you from making progress.

@MuyangAmigo
Copy link
Author

Thanks for your response! Seems outlook is still not an allowed value to be entered.
image

There is a workaround like what you mentioned (Thanks for that!), but our team is building tooling for developing applications for Teams that will generate bicep templates that help with provisioning bot service etc.

Are you suggesting we should reach out to the corresponding RP (bot service I assume) team for this kind of issue?

@alex-frankel
Copy link
Collaborator

Yes, the bot service team needs to update their REST API spec to include this enum value for this property.

@jiaxuwu2021
Copy link

we have alread created a pull request [BotService] Add OutlookChannel to channelNames Azure/azure-rest-api-specs#18149

@alex-frankel
Copy link
Collaborator

Closing this issue. We will track the azure-rest-api-specs PR.

@MuyangAmigo
Copy link
Author

Hey @alex-frankel , I see Azure/azure-rest-api-specs#18149 has been merged, would bicep be automatically updated if so, which version should I use? I have tried Microsoft.BotService/botServices/channels@2021-05-01-preview seems like we cannot find outlook in available channel yet.

@alex-frankel
Copy link
Collaborator

Interesting - I don't see this channel either on Bicep v0.5.6 and our most recent release was 12 days ago and this swagger change was checked in 14 days ago.

image

It is possible we just missed it and generated the types a few days before our release and before this got merged.

@shenglol / @majastrz -- does that sound right? If so, then this will get picked up when we release Bicep v0.6 at the end of the month.

Repro:

resource botParent 'Microsoft.BotService/botServices@2021-05-01-preview' = {
  name: 'foo'

  resource bot 'channels' = {
    name: // open completions here
  }
}

@shenglol
Copy link
Contributor

That's right. The types were generated before the rest API spec PR got merged.

@MuyangAmigo
Copy link
Author

Thanks for the response @alex-frankel and @shenglol , seems like I can expect an updated on Bicep by end of April to pick up the latest swagger change from Bot Service?

@shenglol
Copy link
Contributor

Yes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants