[BotService] Add OutlookChannel to channelNames #18149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @luhan2017 Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
The new version is adding enum value(s) 'OutlookChannel' from the old version. New: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L325:9 |
|
The new version is adding enum value(s) 'OutlookChannel' from the old version. New: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L392:9 |
|
The new version is adding enum value(s) 'OutlookChannel' from the old version. New: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L565:9 |
|
The new version is adding enum value(s) 'OutlookChannel' from the old version. New: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L3166:5 Old: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L3166:5 |
️⚠️LintDiff: 0 Warnings warning [Detail]
- Linted configuring files (Based on source branch, openapi-validator v1.12.1 , classic-openapi-validator v1.2.2 )
- Linted configuring files (Based on target branch, openapi-validator v1.12.1 , classic-openapi-validator v1.2.2 )
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
The response schema of operations API '/providers/Microsoft.BotService/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L742 |
|
The schema 'Resource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L1423 |
|
The schema 'Sku' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L1476 |
|
The schema 'BotProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L1543 |
|
The schema 'BotResponseList' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L1734 |
|
The schema 'AlexaChannelProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L1887 |
|
The schema 'FacebookChannelProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L1930 |
|
The schema 'FacebookPage' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L1970 |
|
The schema 'EmailChannelProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L2003 |
|
The schema 'MsTeamsChannelProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L2040 |
|
The schema 'SkypeChannelProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L2088 |
|
The schema 'KikChannelProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L2152 |
|
The schema 'WebChatChannelProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L2193 |
|
The schema 'DirectLineChannelProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L2229 |
|
The schema 'TelegramChannelProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L2261 |
|
The schema 'SmsChannelProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L2298 |
|
The schema 'SlackChannelProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L2345 |
|
The schema 'LineChannelProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L2420 |
|
The schema 'LineRegistration' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L2445 |
|
The schema 'DirectLineSpeechChannelProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L2484 |
|
The schema 'ChannelResponseList' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L2518 |
|
The schema 'WebChatSite' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L2535 |
|
The schema 'DirectLineSite' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L2582 |
|
The schema 'ConnectionItemName' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L2696 |
|
The schema 'ConnectionSettingParameter' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L2706 |
|
The schema 'ConnectionSettingProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L2720 |
|
The schema 'ConnectionSettingResponseList' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L2785 |
|
The schema 'ServiceProviderResponseList' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L2802 |
|
The schema 'ServiceProviderParameter' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L2819 |
|
The schema 'ServiceProviderProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L2871 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
This was referenced Mar 9, 2022
ArcturusZhang
requested changes
Mar 14, 2022
There was a problem hiding this comment.
Hi @luhan2017 your PR adds a new value to a sealed enum definition, which is usually not allowed and it is a breaking change. Could you please double confirm your changes?
If you want to add this value, please also double confirm whether this will likely happen in the future again, if so, we also need to change the modelAsString to true (which is also a breaking change).
|
Hi @luhan2017, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
|
And @luhan2017 if you confirm your changes are expected, please follow the instructions in this comment to open a breaking change review request. |
JeffreyRichter
added
the
Approved-BreakingChange
@ArcturusZhang I just got an approve from Jeffrey, could you please help review it again? |
ArcturusZhang
approved these changes
Apr 7, 2022
This was referenced Apr 7, 2022
ghost
pushed a commit
to Azure/azure-resource-manager-schemas
that referenced
this pull request
Apr 7, 2022
FredericHeem
pushed a commit
to grucloud/azure-rest-api-specs
that referenced
this pull request
May 16, 2022
* Add OutlookChannel to channelNames * revert the change in stable version
lmazuel
added a commit
that referenced
this pull request
May 21, 2022
* AVS PublicCloud availability is immutable (#18453) * availability is immutable * Update readme.md Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> * [cpim]update readme.python.md (#18562) * update cpim readme.python.md * Update readme.python.md * Update readme.python.md Co-authored-by: ZiWei Chen (WICRESOFT NORTH AMERICA LTD) <v-ziweichen@microsoft.com> * Update swagger for Custom Speech v2.0 and v3.0 (GA) (#18151) * Update swagger/documentation * rename version directories * Add descriptions to enums * clean up typo and unnecessary error response descriptions. * add parameter locations * update quoting * share security * improve operation ids * fix swagger by adding missing schema element * fix security * share schema * fix operation id of health status * REvert operation id changes to be less breaking for existing versions * even less breaking changes * Small fixes to swagger in Microsoft.Sql AdvancedThreatProtectionSettings API for 2021-11-01-preview (#18498) * Added x-ms-identifier for s360 linting issue (#18566) * update Synaspe link connection input file to tag (#18421) * add link connection input file under current tag * add new tag for artifacts package * Merge Cognitive Services - Language version 2022-03-01-preview to main (#18541) Publishes the 2022-03-01-preview version of Cognitive Services – Language pillar including Text Analytics and Conversation Analysis. * Update HealthcareApis.json (#18586) * Adding response code to dataControllers PATCH. (#18556) * Adding properties to DC patch * Adding missing status code to swagger * Update example * Adding location header to example * add-typescript.md-for-cpim (#18569) * [OperationalInsights] Rename 'eTag' property to 'etag' (#18447) * Add blockchain to latest profile * Add additional types * Renamed 'eTag' to 'etag' same as all other ARM resources * rename 'eTag' to 'etag' Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com> * add xms-ids for netapp (#17896) * [BotService] Add OutlookChannel to channelNames (#18149) * Add OutlookChannel to channelNames * revert the change in stable version * [Go]Add batch tag 04/07/22 (#18589) * Add multidimensional Root Cause Analysis APIs in Anomaly Detector Service (#18037) * add multidimentional RCA API * update to 4 tab * update swagger * update swagger with kind * update * update wording * add derived decoration * update schema definition * add more polymorphism * update create dataset * add kin for train, inference, data * update * update * update * update according to review * update query filter * remove nextLinkName * add error code * update * update verion so v1.2-preview * update spelling * update list partition meta * update * update version * update partition * update * update * merge with 1.1-preview.1 version * update * sync with 1.1-preview.1 * update train response * update inference * update version * update description of timestamp * update * update readme * update * update version * update * add x-ms-error-code * update filter description * add 201 response and add kind list * update * update * update comment * update * update * update * upate * format * add emtpy line at end of file * add dataset Id in required for dataset * update * update * Dev kubernetesconfiguration microsoft.kubernetes configuration 2022 01 15 preview (#17516) * Defining the APIs for the new NSP resource * created new branch for 2022-01-15-preview * updated api-version in all file from 2022-01-01-preview to 2022-01-15-preview * updates examples for extension types * updates to extension types spec * updated the readme files * updated tags in readme * adding definitions and parameters under common dir * fixing schema issues * fixing schema issue with extension type list * remove versions from x-ms-pageable in extension type versions * suppress top level resources list by subscription for extension types * copying files from appropriate GA versions to new extnesion type versions folder * updating the API version * updating operations list * Revert "copying files from appropriate GA versions to new extnesion type versions folder" This reverts commit 2247056e66d5d187c6dbdc20d0d76d1d45bf04bd. * adding namespace scope settings to extension types return data * updating location extension types list example * adding latest changes from the previous released version * removing namespace scope settings property * Revert "removing namespace scope settings property" reverting to previous commit tttt reverts commit 00900af7f4b78b7f40a5da0d6346fab73ef08cdc. Reverting to previous commit. * adding "x-ms-identifiers" * removing namespace scope settings * adding x-ms-identifiers * adding x-ms-identifiers * ran preittier fix on parameters.json file * updating tag in readme.md * reverting tag update change from last commit * removing uneeded files * fix for api readiness check * Removing all unrelated example files * Revert "Removing all unrelated example files" This reverts commit 6391df3e8bed5244aa125c6d85a9af855c058060. * Removing all unrelated example files from 2022-01-15 folder * fixing spelling error * quick change Co-authored-by: Hari Prasad Perabattula <harics24@users.noreply.github.com> Co-authored-by: Hari Prasad Perabattula <haperaba@microsoft.com> Co-authored-by: Deeksha Sharma <deesharma@microsoft.com> * Update example grafanaVersion and endpoint (#18610) * Update example grafanaVersion and endpoint * update endpoint * Add new Provisioning state for reservations (#18464) Co-authored-by: Ashok Chhilar <aschhila@microsoft.com> * [Hub Generated] Publish private branch 'appplatform/release/s202' (#18613) * [AutoSync] 35fcc2afb Merged PR 5921627: fix(cve): Upgrade tanzu component image * revert 0501 * fix Co-authored-by: swagger-automation <swagger@microsoft.com> Co-authored-by: Xuyang Cao <xuycao@microsoft.com> * New Api-Version onboarding 2021-12-01-preview (#18478) * Adding 2021-12-01-preview as a copy of 2021-08-01 * Readme update * Updating version in the 2021-12-01-preview folder * update description for keyvault contract (#17150) Co-authored-by: Kacie Kang <jikang@microsoft.com> * fix for the last cherry pick (06d2de8) * fixing readme again * APIM Policy fragments (#16403) * Adding the policy fragments spec * Formatting * Updating descriptions * PolicyFragmentIdParameter as a string * ID validation * Adding fragment description * Adding policy fragment format * Adding raw xml format * Addinga 202 response for creating/updating * Generalising the resource collection * formatting * Moving everything to 2021-12-01 * version fix * Adding pagination params. Generalising the IdParam * Adding missing fields, fixing id param name * Removing link formats. Fixing format param name * POST list references * name filter now supports "contains" * PUT is always async * Fixing header location url * PUT can now return 200 and 201 * Adding more OData query support. Fixing examples. * Resolving the cross breaking change Co-authored-by: Milan Zolota <mizolota@microsoft.com> * Added CORS and CSP configuration resources (#16822) * Added CORS and CSP settings resources. * Added missing definitions. * Added suppression of R4009 for apimportalsettings.json. * Ran Prettier. * Renamed definitions. * Fixed references. * Updated examples. * Reversed change. * Created new resource for portal settings. * Added list example. * Added missing collection contract. * Added missing example. Cleaned up old ones. * Fixed references. * Fixed examples * Fixed version. * Added custom words. Fixed linting. * Fixes. * Fixes. * Fixes. * Fixes. * Fixes. * Fixes. * Fixes. * Fixes. * Fixes. * Fixes. * Fixes * Fixes. * Fixes. * Fixes * Fixes * Removed conflicting constraint. * Updated readme.go.md. * Reverted removing the restriction. * Revert "Reverted removing the restriction." This reverts commit 72d070f6ccc8231e4d4c9f22ac3a9c3090a545aa. * Removed duplicate. * Addressing PR comments. * Adjusted reportUri property type in CSP config contract. (#17947) * Added missing body parameter description for content type resource. (#18036) * Igo/msal client version (#17866) * Added clientLibrary property to IdentityProvider * fixed length for clientLibrary property * Model validation fixes * moved changes for clientLibrary property to the right spec file * Update readme.md Co-authored-by: Milan Zolota <mizolota@microsoft.com> Co-authored-by: Kacie <35987382+KacieKK@users.noreply.github.com> Co-authored-by: Kacie Kang <jikang@microsoft.com> Co-authored-by: Alexander Zaslonov <zaslonov.alexander@gmail.com> Co-authored-by: Igor O <ygrik@hotmail.com> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> * S360 linting issue removed enum from ApiVersionParameter (#18596) * Added x-ms-identifier for s360 linting issue * removed from main * Removed enum from ApiVersionParameter * apiscenario doc (#18476) * sync signalr test scenarios * remove extra template.json * add asc scenarios file * add uploadJar scripts * add uploadJar * add deploymentScripts * update readme * update doc and use blob sas url to download * delete unused powershell file and format scripts * adjust asc scenarios file * update springCloud test scenario * update powershell scripts * v2 schema * fix * prettier * securestring * fix action * fix * fit 2.9.0, waiting for verify * fix domainName * json to yaml * fix output variable type * remove redundent defaultValue in armTemplate * generate uniq name * Adapt to v1.1 schema * remove unnecesary file * fix patch step * update springCloud test scenario * update spring cloud yaml * prettier * add overwrite variable * new schema * delete unused file * rename armTemplateDeployment to armTemplate * webpubsub * v1.2 schema * v1.2 schema * webpubsub * v1.2 schema * adapt asc/signalr to v1.2 schema * more data types in v1.2 schema * v1.2 schema * convert to new syntax * restore example * tiny change * refine variables schema * fix scenarios * fix scenarios * signalr basic crud * cdn scenario coverage 57% * add responses schema * use readmeTag insteadof swagger * fix rp * fix schema * fix step scope variables * fix step variables * fix * [ApiScenario] update doc (#18424) * update doc * Update documentation/api-scenario/how-to/generateABasicApiScenario.md Co-authored-by: Tianxiang Chen <tianxchen@microsoft.com> Co-authored-by: Lei Ni <7233663+leni-msft@users.noreply.github.com> * update docs * fix schema * Update variables.md * commit scenario files * remove scenario files * update schema line * remove resourceUpdate * remove resourceUpdate * requestUpdate convention * convention in pseudo-code Co-authored-by: Zhenglai Zhang <zhenglaizhang@hotmail.com> Co-authored-by: Songbo Wang <sonwan@microsoft.com> Co-authored-by: ruowan <ruowan@microsoft.com> Co-authored-by: Tianxiang Chen <tianxchen@microsoft.com> Co-authored-by: tianxchen-ms <403562789@qq.com> * [operaioninsights][python]Update readme.md (#18615) * Update readme.md * Update readme.md * Update readme.md * change automation bot to azure-sdk (#18513) * add API version 2022-05-01 (#18614) * add API version 2022-05-01 * fix readme * Add EndpointCertificates and bump version for MiLink and ServerTrustCertificates (#18502) * Update readme.python.md (#18619) * Add dapr AppInsights connection string (#18503) * Add dapr AppInsights connection string * Remove the deprecation note for now * update readme (#18621) * Add ScaledAssetDimensions property to Azure Object Anchors (#18552) * copy 0.3-preview.0 as base for 0.3-preview.1 * update api-version to 0.3-preview.1 * Update readme.md * add scaledAssetDimensions to IngestionProperties * Make ParameterValueSpecification reference consistent (#18598) * [Hub Generated] Review request for Microsoft.DocumentDB to add version preview/2022-02-15-preview (#18087) * Adds base for updating Microsoft.DocumentDB from version preview/2021-11-15-preview to version 2022-02-15-preview * Updates readme * Updates API version in new specs and examples * Partition Merge RP API changes * fix spec to reflect the returned value * fix serialization of merge response * Add mongodb API * prettier fix * fixed Linter and Prettier errors * prettier fixes * fix linter errors * address CR feedback * semantic validation fixes * fix mongodb merge example * support for pitr basic/lite * fix pretty and add mongo 4.2 * Adding Support for Client Encryption Policy in swagger spec * Update cosmos-db.json * Update cosmos-db.json * Update CosmosDBSqlContainerCreateUpdate.json * Fixed prettier checl * Fixed prettier check Co-authored-by: Vinh Trinh <vitrinh@microsoft.com> Co-authored-by: Santosh Kulkarni <66682828+kr-santosh@users.noreply.github.com> * [Hub Generated] Review request for Microsoft.LoadTestService to add version preview/2022-04-15-preview (#18534) * Adds base for updating Microsoft.LoadTestService from version preview/2021-12-01-preview to version 2022-04-15-preview * Updates readme * Updates API version in new specs and examples * v2022-04-01-prev, commiting with existing version * update 2022-04-01-preview spec * update examples in 2022-04-01-preview * updated 2022-04-15-preview spec * updated examples for 2022-04-15-preview * updated markdown files * Deleted 2022-04-01-preview from the public spec * prettify json * updated examples to contain encryption properties * Swagger correctness: Fix readonly properties & add additional cluster witness properties (#18573) * Dev-datamigration-Microsoft.DataMigration-2022-03-30-preview (#18213) * Initial Commit * Updating the API version of files * Adding New APIs, examples and properties * fixing model validation and spell check error * Adding Identifier to array * Solving pretty check * Adding TableList and Force delete * Correcting table list example * Updating expand description * Updating examples * Adding filestoragetype on swagger and minmi example * Adding tablelist and sqldbthresholds to examples response * Removing SQLDBbackupconfiguration and RowThreshold (#18473) * fixing s360 errors and adding secure strings (#18593) * fixing s360 errors and adding secure strings * nit error * pretty check * fileshare password as secure string * Revert "pretty check" This reverts commit 677d27c00d5a1185a942873bc02fa54c08fcde03. * nit error * Revert "nit error" This reverts commit 345b38af7f3344a85d666b547acd91fd769a66d2. * removing extra space * moving targetDatabaseCollation and provisioningError Co-authored-by: Vasundhra Manhas <vmanhas@microsoft.com> Co-authored-by: Vasundhra Manhas <42461257+vasundhraManhas@users.noreply.github.com> Co-authored-by: Vasundhra Manhas <vmanhas@microsoft.com> * Update costmanagement.pricesheets.json (#18377) * Update costmanagement.pricesheets.json * Update costmanagement.pricesheets.json * Update EventGrid.json (#18397) * Update EventGrid.json * Update EventGrid.json * Add new PR templates for control plane and data plane PRs (#18509) * config azurestackhci readme.java (#18641) * set `x-ms-client-flatten` to `false` in `arcSettings.json`, `clusters.json` and `extensions.json` * fix extensions * [ContainerService] [postgresql] [Solutions]Change track2 to python (#18617) * update tag * Update readme.python.md * Update readme.python.md * Active Directory connector automatic mode properties (#18588) * Active Directory connector automatic mode properties * fixed capitalization * adding new property to examples * Service Fabric Managed Clusters - api version 2022-02-01-preview (#17883) * initial commit copy from 2022-01-01 * update specs with api version 2022-02-01-preview update readme with version 2022-02-preview add missing x-ms-enum and add azresiliencystatus to custom words add x-ms-identifiers to arrays fix x-ms-identifiers * change /azresiliencystatus to post * change parameter name to isSpotVM * change path to getazresiliencystatus as suggested by ARM * fix custom word getazresiliencystatus Co-authored-by: Alfredo Santamaria Gomez <alsantam@microsoft.com> * [Azure Data Factory] Support rest-based connectors in ADF (#18514) * Updating Dataworld in custom words file * Updating Linkedservice details with Dataworld information * Update LinkedService.json * Asana Swagger changes * swagger changes for appfigures * Update LinkedService.json * Twilio linked service changes for datafactory * Synapse linked service changes for Twilio * Twilio custom-words.txt change * Resolving conflicts * removed extra comma Co-authored-by: Aravind Reddy <akv@microsoft.com> Co-authored-by: Priyadarshi Ghosh <prgh@microsoft.com> Co-authored-by: mshrivastavamsft <103027908+mshrivastavamsft@users.noreply.github.com> * Add zoneredundancy property (#18582) * Add zone redundant flag and fix label samples * add mutability * Skumar/rch metadata api (#18279) * Defining the APIs for the new NSP resource * adding metadata API details * updating ResourceHealth.json * fixed resourcehealth.json * fixing linter issues rch metadata * prettier fixes * additional linting fixes * additional linting fixes * suggesting lintf fixes * model fixes * model fixes 2 * model fixes 2 Co-authored-by: Hari Prasad Perabattula <harics24@users.noreply.github.com> Co-authored-by: Hari Prasad Perabattula <haperaba@microsoft.com> * Update AlertRules.json (#18640) * Update openapi-authoring-automated-guidelines.md (#18420) * Update openapi-authoring-automated-guidelines.md * Update openapi-authoring-automated-guidelines.md * [Synapse] extract common definition for `CloudError` (#18636) * configuration * optimize common definition * update * fix * Update readme.python.md * Add host, schemes, comsumes and produces (#18668) * Traz rozner/rebranding api docs from asc to mdfc (#18477) * changed 'Azure Security Center' to 'Microsoft Defenders for Cloud' in the relevant defender's descriptions * another brand name to 'Microsoft Defenders for Cloud' * change brand name to 'Microsoft Defenders for Cloud' in locations.json * changed 'title' fields from 'Security Center' to 'Microsoft Defender for Cloud' Co-authored-by: Tuval Rozner <t-trazrozner@microsoft.com> * Adding identity to RegistryCredentials (#18508) * New 1.2-preview release for IoT Central API (#18383) * New 1.2-preview release for IoT Central API, Add support for Device Group CRUD, New Job Types * update package version in readme.md * fix lint errors * add missing contract * Fix API Review Comments, Add Default Error Response, Revise the filter description in device group, define any value for capability job * fix description of organization parent field * fix code review comments * remove version enum, fix code review comments * Update specification/iotcentral/data-plane/Microsoft.IoTCentral/preview/1.2-preview/iotcentral.json Co-authored-by: Mike Kistler <mikekistler@microsoft.com> * add missing comma * fix the code review comments to add application/json-merge-patch only support for device group * fix comments * add description for non-collection definitions * add paging for /jobs/:id/devices * fix typo Co-authored-by: Mike Kistler <mikekistler@microsoft.com> * add alert rule template version to stable version of the API (#18658) * update service linker readme for sdk generation (#18684) * Highlight required actions in PR templates (#18681) Also includes a few other markdown fix-ups. * [Go] Add directive eventhub,servicebus (#18672) * Review request for Microsoft.ContainerService to add version 2022-03-02-preview (#18633) * Adds base for updating Microsoft.ContainerService from version preview/2022-02-02-preview to version 2022-03-02-preview * Updates readme * Updates API version in new specs and examples * feat: add `/rotateServiceAccountSigningKeys` API (#18359) * feat: add `/rotateServiceAccountSigningKeys` API * chore: remove duplicated description * feat: add `workloadIdentity` settings to `SecurityProfile` (#18360) * fix: update example name (#18382) * add creationData to mc data (#18414) * add creationData to mc data * fix test * fix format * Add API properties and example JSON for Web App Routing of IngressProfile (#18564) * Add API properties and example JSON for Web App Routing of IngressProfile. * Add a ending period for description to match the style in all other "descriptions" in the same file. * Update readmes for the 2022-03-02-preview dev branch of container service (#18358) * update readme * update sdk readmes * Agentpool alias minor version 2022-03-02-preview (#18381) * Add field currentOrchestratorVersion to support Agentpool alias minor version * Add new exmaple for alias minor version * Remove example for PrettierCheck * Fix typo * Latest patch version supported is 1.22.7 at the moment * Address comments - refine descriptions for fields * feat: add ManagedCluster StorageProfile in 0302preview (#18590) Signed-off-by: Ji An Liu <jiliu8@microsoft.com> * Swagger change for ignore-pod-disruption-budget (#18548) * Swagger change for ignore-pod-disruption-budget * Change ignorePodDisruptionBudget to string in example file. * Change ignorePodDisruptionBudget to boolean type. * add effectiveNoProxy for AKS (#18544) * add effectiveNoProxy for AKS * add to correct api * fix lowercase -> uppercase O * spelling * Replace common type definitions with references since 2022-03-02-preview for Microsoft.ContainerService (#18567) * replace Resource * replace SystemData * replace parameters * change track2 to python Co-authored-by: hbc <bcxxxxxx@gmail.com> Co-authored-by: Qingqing <qizhe@microsoft.com> Co-authored-by: Yi Zhang <yizhang5@microsoft.com> Co-authored-by: Thalia Wang <58485997+wenxuan0923@users.noreply.github.com> Co-authored-by: Ji'an Liu <jiliu8@microsoft.com> Co-authored-by: Tong Chen <45081443+tonche@users.noreply.github.com> Co-authored-by: Ace Eldeib <aleldeib@microsoft.com> * update servicelinker enum name (#18687) * [Hub Generated] Review request for Azure.Analytics.Purview.Catalog to add version preview/2022-03-01-preview (#18262) * Adds base for updating Azure.Analytics.Purview.Catalog from version preview/2021-05-01-preview to version 2022-03-01-preview * Updates readme * Updates API version in new specs and examples * add new atlas2.2 API spec * refactor the structure of the new APIs * refactor the structure of the new APIs-2 * fix validation error * add description * add description-2 * fix wording issue * fix double / typo issue * Adding new input enum value to Microsoft.Capacity version 2022-03-01 (#18646) * Review request for Microsoft.ContainerService to add version 2022-03-01 (#18686) * Adds base for updating Microsoft.ContainerService from version stable/2022-02-01 to version 2022-03-01 * Updates readme * Updates API version in new specs and examples * Update readmes for the 2022-03-01 dev branch of container service (#18357) * update readme * update sdk readmes * feat: add ManagedCluster StorageProfile in 0301 (#18594) Signed-off-by: Ji An Liu <jiliu8@microsoft.com> * Replace common type definitions with references since 2022-03-01 for Microsoft.ContainerService (#18568) * replace Resource * replacing systemData * replace parameters * fix: replace Resource with TrackedResource * replace track2 with python Co-authored-by: Ji'an Liu <jiliu8@microsoft.com> * [resources][python] update configuration (#18591) * add configuration * Update readme.python.md * Update Microsoft.Resources tag for SDK Generation (#18683) * Update readme.md * Update readme.md * Update readme.md * Update readme.md * [Hub Generated] Review request for Microsoft.CostManagement to add version stable/2021-10-01 (#18676) * Adding common-types u u u * Adding common-types u u u u:x * Fixing common-types ref in exports.json * Fixing references and remove Resource definition * Reverting changes to pricesheets * Adding Operations_List example * Adding example * Reverting breaking change * Reverting a breaking change and using ApiVersionParameter from types.json * Reverting api-version parameter change since that flagged as a breaking change * Dev cost management microsoft.cost management 2022 02 01 preview (#17856) * Add new Azure Object Anchors API version 0.3-preview.0 (#17117) * add 0.3-preview.0 * fix INVALID_FORMAT * [Hub Generated] Review request for Microsoft.AlertsManagement to add version stable/2021-08-08 (#17162) * Adds base for updating Microsoft.AlertsManagement from version preview/2021-08-08-preview to version 2021-08-08 * Updates readme * Updates API version in new specs and examples * 1. added input files to new tag 2. changed alerts management client tag to the new tag Co-authored-by: Liran Englender <lienglender@microsoft.com> * Add batch tag for streamanalytics readme.go.md (#17191) * Add batch tag for streamanalytics readme.go.md * fix * S360 - fixing pending 3 Swagger KPIs (#17195) * Update ResourceHealth.json fixing Swagger changes * Update ResourceHealth.json fixing PR checks * Create Operations_List.json add new file * Add AML skill to preview swagger for Search Service (#16910) * add aml skill to preview swagger for search service' * update * Fixing S360 issues (#17014) * Fixing S360 issues * Fix style * Add specs for ACS Chat preview7 (#16887) * Baseline using previous API version * Updates for preview7 * Update readme.md * Prettier fix * Fix readme * Fix example for update-participant Co-authored-by: Po Tsang <tsangpo@microsoft.com> * Add servicePrincipalCredentialType and servicePrincipalCredential into AzureBlobFSLinkedService (#17036) * Add servicePrincipalCredentialType and servicePrincipalCredential into AzureBlobFSLinkedService * update * revert some change * Device update public preview refresh (#17205) * Batch2: approved PR 4891 https://github.com/Azure/azure-rest-api-specs-pr/pull/4891 * Batch3: minor updates (PR 5556) https://github.com/Azure/azure-rest-api-specs-pr/pull/5556 Co-authored-by: Laurent Mazuel <laurent.mazuel@gmail.com> * Azure Synapse Workspace PublicNetworkAccess Fix (#17210) Co-authored-by: Nikhil Kumar <nikhilkumar@microsoft.com> * 2021-08-01-only (#17224) * [NetApp Files] Bug Fix volumeGroups tag, backup properties creationDate and examples (#17157) * Fix volumeGroups tag, bakcup properties creationDate and examples * Fix Staging model validations * Example ref * Microsoft.OperationalInsights: 2021-12-01-preview (#17138) * Microsoft.OperationalInsights: tables privatepreview * Microsoft.OperationalInsights: tables privatepreview * Microsoft.OperationalInsights: tables privatepreview * code review changes. * Update Tables.json * Update Tables.json * OperationalManagement: 2021-12-01-preview * more fixes. * Update Clusters.json * Tables: Sentinel+CLV2 changes. * Tables: More descriptions. * removing un related child resources. * Create OperationsListByTenant.json * Update Tables.json * Update TablesGet.json * Add systemData example. * Model fixes + pretty * adding description to ip data hint. * Update Tables.json Co-authored-by: Dudi Likvornik <dulikvor@microsoft.com> * [DO NOT MERGE ] Introduce new scanners resource type (#17107) * introduce new scanners resource type * fix error * fixing errors * fixing errors * fix error * fixing errors * fixing comments * adding new tag * Azure Batch 2022-01-01.15.0 Data Plane Update (#16960) * Initial commit for comparison * Update BatchService Swagger file PR Feedback * Update examples Ran prettier * Updated readme Fixed tag * Language API for TA (2021-11-01-preview) (#16256) * WIP for language api spec for TA * Updated preview version number; finished up async definitions * Finished first draft of full spec * Finished first draft of full spec, minus FHIR structuring in HC output * Removed features not included in 2021-11-01 preview * Update custom text tasks TODOs * Moved common definitions to TA-specific definitions * Added custom text tasks to JobManifest * Addressing feedback from PR comments and internal review * Addressed some PR comments * Updated some remaining references to documents * PR comments * Updated a previous change * Reverted references to 'records' back to 'documents' * A few small updates to examples; removed base Task type to simplify structure * PR comments * Addressed TODO items; removed LD-related objects (will be added in another preview) * Fixed anonymous types * Removed required field for body in POST request * Fix prettier check * Added a few more details; experimental change for documents property * Ran prettier * Correction to AnalysisInput object * PR comments * Added custom entities task to examples * PR comments * Prettier check * Troubleshooting model validation failure Co-authored-by: Abigail Hartman <Abigail.Hartman@microsoft.com> Co-authored-by: Kareem Yousef <kayousef@microsoft.com> Co-authored-by: Abby Hartman <abhahn@microsoft.com> * Fix flipped order in Face generated models (#16846) * Fix flipped order in Face generated models The recent change changing a nested parameter from optional to required caused the AutoRest generated model to have a reversed order of two string arguments. Expanding the nesting for affected models to avoid breaking changes. * Fix malformatted examples * Update Resources.json (#16996) * Update Resources.json * Specify additionalProperties type * CDS component type update - mismatch between swagger and code values (#17183) * [Hub Generated] Review request for Microsoft.CostManagement to add version preview/2020-12-01-preview (#13609) * Latest * Latest * Latest * Latest * Latest * Latest * Latest * Latest * Latest * Latest * Latest * FixS360 | Microsoft.Billing (#13771) * fixing billing accounts and operations * adding total count. * typo fix * fixing spell check and prettier * Vakuncha changingcsharpreadme (#13806) * Update readme.csharp.md * Update readme.csharp.md * [aks] fix vm size model and osDiskType description (#13763) * fix: agent pool vm size should be string, not enum * fix: osDiskType default description for >= 2020-11-01 * [Hub Generated] Review request for Microsoft.DocumentDB to add version preview/2021-03-01-preview (#13267) * init * fix format * sync * read only * fix sample * fix Co-authored-by: Teng Pan <tepa@microsoft.com> * storagesync readme t2 config (#13810) * storagesync readme t2 config * storagesync readme.python t2 config * Updated SAS swagger with latest changes. (#13439) * Fixed hostname in the Offazure swaggers. * added newest swagger from service repo. This contains PE changes too. * rewritten swagger changes on existing swagger * some fixes to swagger * added examples. * fixes * edit * edit. * fixes * minor fix * edit * edit * edited default api version tag * Dev weather microsoft.maps 1.0 (#13796) * Remove preview from Weather API, remove X-Publish, and convert X-ms-enum ModelAsString to true * Revert changes to package-lock.json * Fix spelling error * Adding Azure Object Anchors error codes for IngestionProperties (#13787) * Added Azure Object Anchors error code field to IngestionProperties * Fixed spacing in example * Moved changes to new version * Addressed version mismatch, spacing * Fixed versions on examples * Readonly error code * Seeing if readonly error code is breaking * Revert "Seeing if readonly error code is breaking" This reverts commit c0b16f07c4a46a07fc7831a1735bb290804242ea. * Model error code as string * Renamed examples to asset conversion nomenclature * Fixed rename issues * Fixed issue #9593 (#13262) * Fixed issue #9593 * Removed redundant PrivateEndpointConnectionProperties attribute * [Hub Generated] Review request for Microsoft.Consumption to add version stable/2019-05-01 (#13800) * Fixed Swagger Validation Errors * Fixed Model Validation * [Hub Generated] Review request for Microsoft.CostManagement to add version stable/2019-11-01 (#13788) * Fixed Swagger Validation Errors * Fixed Type * Fixed Type * Fixed Setting Properties * Fixed Punctuation * Removed Item * Added Items Properties * Fixed Required Property * azurestack wave4 t2 config (#13813) * Added Microsoft.AppConfiguration 2021-03-01-preview API version. (#13490) * Added Microsoft.AppConfiguration 2021-03-01-preview API version. * Add system metadata to tracked resources in "Microsoft.AppConfiguration". Updated ConfigurationStore to reference the common tracked resource type definition. * Added disableLocalAuth property. * Add new api version swagger to readme. * Added/updated examples and added suppressions for standardized APIs. * Fixed prettier. * Add missing property fileStorageSkuName into MySQL Flexible Server spec (#13693) * appplatform t2 readme config (#13829) * customproviders t2 readme config (#13831) * Update readme.csharp.md (#13807) * [Sentine][Data connectors][Fix correctness bug] (#13175) * update required fields * update required fields * Explicitly define KeyCreationTime in Feb21 (#13757) * Explicitly define KeyCreationTime Explicitly define KeyCreationTime * Fix KeyCreationTime Example Fix KeyCreationTime Example * Add Microsoft.M365SecurityAndCompliance RP (#13646) * Add Microsoft.M365SecurityAndCompliance RP * fix datetime and common-types file path * update common-types file path * add preview path in readmego * replace stable with preview * remove duplicate tags * refer MIPPolicySync json in readme * service name for java (#13837) * Dev keyvault microsoft.key vault 2021 04 01 preview (#13585) * Adds base for updating Microsoft.KeyVault from version preview/2020-04-01-preview to version 2021-04-01-preview * Updates readme * Updates API version in new specs and examples * Open API change for Managed Hsm private endpoints feature (#12938) * Open API change for Managed Hsm private endpoints feature * Fixing spell check errors * Fixing spell check errors * Prettier fixes * Fixing swagger validation errors * Fixing systemData property reference * Adding publicNetworkAccess property based on private endpoint requirement. * GET responses following a successful DELETE should be returning 404. … (#13054) * GET responses following a successful DELETE should be returning 404. Only the DELETE response is to return 204 if the resource didn't exist (it allows idempotent deletes). (cherry picked from commit b752a19c6cc1f8a8eed9f106e2c77b8d5b5db19f) * Removing 404 as it is taken care by default response. * Added new routes for Deleted ManagedHsm for Soft Delete Feature (#13282) * Added new routes for Deleted ManagedHsm and examples, updated ManagedHsm definition to include PurgeDateTimeUTC * Fixing validation issues. * Fixing errors in properties in example jsons * Delete keyvault.json Deleted an errant json file * Fixed misspelling of property in examples * Fixed x-ms-examples naming, fixed camelcasing * Addressing comments in PR to make 204s 404s and also changing PurgeDateTimeUTC to scheduledPurgeDate * Added schema definitions for 404 * Removed 200 for purge Co-authored-by: Soohwan Kim <sookim@microsoft.com> * Addressing Comments for PR 13585 (#13586) * Removed 404s to allow requests to fall through to default * Removing 404s from examples Co-authored-by: Soohwan Kim <sookim@microsoft.com> * Added deletedmanagedhsm object to examples and managedhsm.json (#13591) * Added deletedmanagedhsm object to examples and managedhsm.json * Fixing error in references to correct values * Changed vaultId to mhsmId in exmaples Co-authored-by: Soohwan Kim <sookim@microsoft.com> * Try to use the common type for SystemData (#13723) * Add SystemData property for KeyVault * 04012021 fix schema (#13749) * Resolving conflict with custom-words.txt * Add 2021 preview to azureresourcechema, add suppression to readme * Add 2021 preview to azureresourcechema * Merging custom-words.txt Co-authored-by: Soohwan Kim <sookim@microsoft.com> * Add missing default error response (#13762) * Fix Lint error (#13765) * Add missing default error response * Update the integer format to fix Lint error * Add securityDefinitions * Added python tag for 2021 preview (#13805) Co-authored-by: Soohwan Kim <sookim@microsoft.com> * Fixing linting errors for MHSM R4036 - ImplementPrivateEndpointAPIs (#13822) * Fixing linting errors for MHSM R4036 - ImplementPrivateEndpointAPIs (cherry picked from commit c1c5aebfb98cacd0a4ee5596fb7b0d9f782a9a3e) * prettier fix * Add suppression for SystemData (#13835) * Add suppression for SystemData * Fix linting error R4036 - ImplementPrivateEndpointAPIs * specify the suppression for SystemData * Revert "specify the suppression for SystemData" This reverts commit cbebab81ab08ec1a29b41c891c58cf08ff2eb3c4. Co-authored-by: jiacheng-L <71623842+jiacheng-L@users.noreply.github.com> Co-authored-by: kim-soohwan <40476315+kim-soohwan@users.noreply.github.com> Co-authored-by: Soohwan Kim <sookim@microsoft.com> Co-authored-by: Arthur Ning <57385816+akning-ms@users.noreply.github.com> * hybridnetwork only track2 configure (#13832) * hybridnetwork only track2 configure * remodify * namespace del Co-authored-by: Yan Zhang (WICRESOFT NORTH AMERICA LTD) <v-yanzhang@microsoft.com> * terraform readme for alertsmanagement (#13744) Co-authored-by: Your Name <you@example.com> * add tags back in the adp readme (#13850) * Add device principal type (#13799) * copy files from previous version * add device principal type, update versions * fix * system data requirement * Added CheckNameAvailability, Identity, systemData, used ErrorResponse v2 in DeviceUpdate (#13750) * Update deviceupdate.json * Update deviceupdate.json * Add files via upload * Update deviceupdate.json * Update deviceupdate.json * Update Accounts_Update.json * Update Accounts_Create.json * Update Instances_Create.json * Update deviceupdate.json * Linux line ending * Update CheckNameAvailability_AlreadyExists.json * Update CheckNameAvailability_Available.json * Update CheckNameAvailability_AlreadyExists.json * Update CheckNameAvailability_Available.json * Update CheckNameAvailability_AlreadyExists.json * Update CheckNameAvailability_Available.json * Update deviceupdate.json * Update deviceupdate.json * fixed typo in the example files (#13764) * Update CODEOWNERS (#13795) Updating list of Azure Cognitive Search team members * Update GenerateDetailedCostReportBySubscriptionAndTimePeriod.json (#13772) Update example data * [Hub Generated] Public private branch 'stuartko/Mar21_NewTSVersion' (#13811) * Adding version 2021-03-01-preview (copy of previous version) * Adding new metadata property * Adding uiDefinition property. * Update uiDefinition name to uiFormDefinition (per a change by the service feature author). No change to functionality. * Template Specs: Renaming template to "mainTemplate" and changing "artifacts" to be more specific "linkedTemplates". * Swagger changes for 2021-02-01-preview api version (#13794) * Copy existing preview version * Changes to databoxedge json file * Update readme files * Correct Spell Check * Fix Readme.go error * Update examples * Update all schemas.md files (#13862) * typo: implmentation -> implementation (#13644) * Add MongoDB/MongoDBAtlas sink (#13669) * Add MongoDB/MongoDBAtlas sink, add disableMetricsCollection in read/wirte properties * Revert disableMetricsCollection related changes * Azure ML new API version 20210401 (#12981) * Add Identity to createWorkpace example * change for getTransitivePEUsages * update * prettier code * add another new endpoint * address comments * change for getTransitivePEUsages * update * prettier code * add another new endpoint * address comments * revert change on transitivePE and notebookKeys * revert change on transitivePE and notebookKeys * add new stable version 2021-01-01 * add ListNotebookAccessToken * add primaryUserAssignedIdentity * fix missing properties and apis * fix one more missing property * 202 status for start and stop CI * make resync keys long runnin operation in version Jan2021 * resync keys 204 * update resync keys example * Dont throw 204 for resync * update resync keys * Formatting * revert Jan2021changes and add new version * start apr2021 version for azure ml rp * undo remove new line in jan2021 * use systemData definition in common * removed old files * fix small swagger bugs * run prettier * remove reference to sku * update readme * minimum agentCount should be 0 * add createdOn and ModifiedOn to compute properties * add LoadBalancerType to aks compute * add isNotebookInstanceCompute to virtualMachine * add leafDomainLabel to SslConfiguration * add overwriteExistingDomain to SslConfiguration * add synapseSpark as supported compute-type * update patch compute response to 202 * remove location from example responses * Revert "remove location from example responses" This reverts commit 048bf2551513afae842a9c4fbb5861aeddc6c33a. * MachineLearningCompute_Update should have a 200 response * sys data to use local def due to naming conflicts. * Fix enum casing * Fix operationId PR comment. * Change opId in apr version * remove 20210401 for easy review * only change api version * merge changes for 20210401 version * Add x-ms-discriminator-value for Synapse spark * camelcase loadbalancer properties * add createdOn and Modified on to examples * address AvoidAnonymousTypes error for SynapseSpark * Minor fixes + new property * Remove subscription state. Co-authored-by: zhaomuzhi <zhaoweixiong521@gmail.com> Co-authored-by: Vinay Rajmal Soni <vison@microsoft.com> Co-authored-by: jopet@microsoft.com <jopet@microsoft.com> Co-authored-by: Josh Peterson <15050193+joshanator@users.noreply.github.com> * datashare readme t2 config (#13833) * add readme terraform (#13717) * adding a new API version for Restore API and adding targetVirtualMachineId field for AzureWorkloadRestoreRequest (#13638) * copying previous change * Adding targetVirtualMachineId field for Azure Workload Restore requests * updating crr version and examples * removing new api-version * adding back the new api-version * removing Snapshot related fields * updating readme.md * corrected the path Co-authored-by: Chandrika Gonuguntla <chgonugu@microsoft.com> * chore: resort custom-words.txt from bad merge (#13868) * [ApplicationInsights] Fix failure for python SDK (#13875) * [Hub Generated] Review request for Microsoft.Insights to add version preview/2020-10-05-preview (#13712) * Adjustments to API to include validation grouping and updated text. * Fixed missing curly brace * adjusted name * Added basic and standard examples * adjusted type. * corrected case for key value * [Hub Generated] Review request for Microsoft.Insights to add version preview/2021-03-03-preview (#13269) * Adds base for updating Microsoft.Insights from version preview/2020-10-05-preview to version 2021-03-03-preview * Updates readme * Updates API version in new specs and examples * Add DiagnosticServiceToken API * Update examples to split tokens for readonly vs readwrite * Fix accoding to code review feedback * Update examples due to review feedback from ARM * add configuration for vmware (#13879) Co-authored-by: Your Name <you@example.com> * keyvault t2 config (#13863) * keyvault t2 config * keyvault multi-api config * multi api config * config reset * add package version * hanaonazure t2 readme config (#13880) * Remove x-ms-azure-resource (#13500) Co-authored-by: Dongwei Wang <dongwwa@microsoft.com> * Juniwang/sr202010401preview (#13664) * prepare to add new api-version: copy everything from 2020-07-01-preview * Adding new api-version * Fix required body and annotate ms secrets * remove secrets example from swagger * fix prettier * add datashare terraform configuration (#13876) Co-authored-by: Your Name <you@example.com> * storage readme t2 config (#13881) * storage readme t2 config * storage t2 config * healthcareapis t2 config (#13884) * typo: APIkeys -> APIKeys (#13641) * Allow release_policy to be nullable (#13826) * Fix type of Anserws and Captions (#13872) * change the value of license header (#13886) * [Synapse] - library_append API adds comp parameter (#13841) * [Synapse] - add comp parameter * Update example files Co-authored-by: Dongwei Wang <dongwwa@microsoft.com> * Remove 200 response from async operation (#13190) * Async operation always returns 202 on initial call * Address review feedback * Revert "Address review feedback" This reverts commit 9ae550b95c1082c8383595a943a9abe5990fd4ef. * add minimal tls version for mariadb (#11779) * [Synapse] - add Swagger code owner (#13882) Co-authored-by: Dongwei Wang <dongwwa@microsoft.com> * add con figuration for databoxedge (#13877) Co-authored-by: Your Name <you@example.com> * add configuration for resourcemover (#13878) Co-authored-by: Your Name <you@example.com> * Reduce code owner scope for Monitor.Exporters team (#13898) * [portal]Update readme.python.md (#13907) * Update readme.python.md * Update readme.md * Update readme.python.md * Update readme.python.md * Dev dfp microsoft.dfp 2021 02 01 privatepreview (#13305) * New Readme Config File * New Go Language Readme Config File * New Azure AZ Readme Config File * New Azure CLI Readme Config File * New Typescript Language Readme Config File * New Python Language Readme Config File * New C# Language Readme Config File * New AzureResourceSchema Readme Config File * New Swagger Spec File * New Swagger Example Spec File * DFP API specs. Copied from Azure-PPE * Spelling fix. instnace => instance * Fix resource provider name to pascal case * Added '/providers/Microsoft.Dfp/operations' * Added SystemData (fix R4009 error) * Fix validation errors * Prettier fixes * Removed non-existend parameter sku * Style fixes in DFP API specs * Swagger ModelValidation failures fix * Fix operations API * Fix operations API validation failure * 1. Added example for lists operations. 2. made the API preview instead of privatepreview * Fix path in readme's * Fix in readme * Added readonly attribute to systemdata * Added readonly attribute to systemdata * Fix in python SDK readme * Fixes in ListOperations.json examples * Fixed API version * Added type to response bodies * Fix typos in examples (urls) * Added 201 response into createInstance example * Renamed RP name from Microsoft.Dfp to Microsoft.Dynamics365Fraudprotection * Added long-running result for creation instance * Added nextlink * Fix in checkNameAvailability definition URL * Next link parameter * Using references to common types instead of re-declaring them * Reused common type. Fixed provisioning state * Nesting error fix * Fixed examples * Fix * Fix in error response definition * Rename RP. Fix examples in readme's * Added http 202 * Added http 202 to examples * [Hub Generated] Review request for Microsoft.InstanceMetadataService to add version stable/2020-10-01 (#13818) * Adds base for updating Microsoft.InstanceMetadataService from version stable/2020-09-01 to version 2020-10-01 * Updates readme * Updates API version in new specs and examples * Adding new fields for 2020-10-01 * Updating wording for disablePasswordAuthentication' Co-authored-by: jmccarthy <jmccarthy@microsoft.com> * Remove name check from client side (#13492) * remove name validation from client side * remove name check from deploymentScripts swagger * remove name check from previous swagger versions * remove pattern from resourcegroupname parameter * Update deviceupdate.json (#13900) * [Hub Generated] Review request for Microsoft.ResourceHealth to add version stable/2018-07-01 (#13817) * Updated api-version * Removed systemData * Updated api-version * Updated the example * Add EligibleChildResources resource for PIM + update examples (#13803) * PIM API Specs * update readme * Update * Update readme * operation id fix * name fix * Name changes * fix * Fix * Changes based on docs generated * Scope fix in example * Updates for documentation * Change operation name * Update examples * Add expanded properties * Fix formatting * Fixes * Fix * fixes * Update the policy specs * Fix the policy objects and pell checks * fix the checks * fix the property * fix syntax * Prettier * Update Examples * Update Enums * ADd eligible child resource API specs * prettier fix * Update read me files * update * update * fix * update * Update Enums * update * update * update * update example Co-authored-by: Aman Swaika <amansw@microsoft.com> Co-authored-by: Gaurav Mishra (IDENTITY) <gamish@microsoft.com> * refine readme.go.md (#13906) Co-authored-by: Your Name <you@example.com> * [Service Fabric Managed Clusters] adding api version 2020-05-01 (#13860) * initial commit 2021-05-01 to compare with previous version 2021-01-01-preview * update models * update examples * fix isStateless description * add 2021-05-01 version to readme * add x-ms-enum to diskType and add missing managedClsuterVersions paths fix example names add managed cluster version paths add default error * fix clusterversion by version and ClusterState descriptions Co-authored-by: Alfredo Santamaria Gomez <alsantam@microsoft.com> * Task 9639284: Swagger changes for new UK agreement templates (#13895) * Task 9639284: Swagger changes for new UK agreement templates * Renamed as per comments. Co-authored-by: Umang Shah <umangshah@microsoft.com> * Confluent new preview version + S360 fix (#13809) * Adding new API version for Microsoft.Confluent * Prettier fix * updated status property in OfferDetail updated status property in OfferDetail to fix swagger correctness issue * fix swagger live validation updated operations response to fix swagger live validation Co-authored-by: Srinivas <alluri02@users.noreply.github.com> * [Hub Generated] Public private branch 'juniwang/wps' (#13905) * Onboarding Azure WebPubSub service * reference ErrorResponse from common types and adding network ACL * disable cors, enable feature flags and fix several policy violations * remove anonymousConnectPolicy since it's not ready for now * add property publicNetworkAccess per NRP requirement * revert package-lock.json * reset package-lock.json * dns t2 readme config (#13923) * update readme (#13918) * add current readmes for generating python form recognizer (#12013) * add current readmes for python form recognizer * fix release tag * updates for multiapi and preview.3 * fix so that gen code outputs in generated folder * remove tag since swagger not in yet * unbreak build * just target preview 3 * don't run track 1 gen with python * Set x-ms-api-version to false for vaults list (#13924) * Set x-ms-api-version to false for vaults list (#13925) * Update event description to include the event name (#13867) * Update event description to include the event name * Update readme to include guidelines for defining a new event * Fix description * Renamed enum values for SDK auto generation (#13938) * Renamed enum values for SDK auto generation * Tabs to spaces * Newline added * [Document Translator] update operation names (#13915) * update operation names * make body required * Update ErrorName * Apply changes to stable * Fix samples * fix sample * Fix glossary sample * Address comments and update definitions names * Revert "Task 9639284: Swagger changes for new UK agreement templates (#13895)" (#13946) This reverts commit ea5bc27ee9cadeb67767d774c82095be2420bcad. * Adding new preview API for promotions (#11599) * Adding new preview API for promotions * Avacado fix * Fixing JSON * fixing the promo param * fixning linting issues * Fixing JSON * fixing JSON * fixing linting issues * Adding delete 204a * Adding delete 204 * Adding validation fixes * fixing spellings * Linting issues * running prettier * ARM review feedback * Fixing linting issues * Fixing prettier * Fixing version * Fixing SDK * fixing go sdk * revert go.md Co-authored-by: Rishi Kapoor <rishik@microsoft.com> * Exposing undocumented Databricks workspace properties for fixing S360 issues (#13683) * exposing storage account name, sku * Prettier fixes * Fixing the review comment * Adding No Public IP related properties * Updating the remaining properties related to S360 * Fixing review comments * Fixing Spell Check issue * hybridcompute readme t2 config (#13910) * readme t2 config * hybridcompute t2 readme config * web readme t2 config (#13909) * web readme t2 config * web readme.python t2 config * Add x-ms-api-version (#13834) * Update CheckNameAvailability_Available.json (#13914) * webpubsub t2 config (#13949) * Update StaticSite.json (#13768) * Update StaticSite.json Add private endpoint connections to static site object. * Update StaticSites.json * Update StaticSites.json * Update StaticSites.json * Update StaticSites.json * increment readme version * address PR comments * add examples * fix examples * Add data-plane samples creation template (#13528) * Add data-plane samples * Simplified template * webpubsub readme t1 del (#13953) * Add $(multiapi) to QnA Maker's readme.md (#13819) Generators were processing every tag when only a single one was desired. This is the common solution to support multi-api SDKs. * IoT data-plane for drwill-ms (#13964) * add missing usage.json to v5 sdk tag (#13960) * [Hub Generated] Review request for Microsoft.Kusto to add version stable/2021-01-01 (#13306) * Add new api version 2021 * remove managedIdentity since we won't support it in this version * CR comments * Add default value for contine on errros * Fix swagger correctness issues * Fix typo * resource t2 readme config (#13974) * Added new API and API version for private DNS zone suffix (#13789) * Added new API and API version for private DNS zone suffix * trigger validation pipelines * Add new API to readme * Fix ARM pipelines * Try fix again * Fix again * Add Operations API * Revert "Add Operations API" This reverts commit 9d4ca9e557763feb3a6089ff9d4c958b3843730e. * Revert "Revert "Add Operations API"" This reverts commit 7cf197c1d453764f0396713a2ab172a20e35b1c4. * Revert "Revert "Revert "Add Operations API""" This reverts commit 05744390e440984da8134b64a979a6e61fb9b7ae. * Revert "Revert "Revert "Revert "Add Operations API"""" This reverts commit 61b76b1623d9e5796bb8187edf0fc46351e78231. * Revert "Revert "Revert "Revert "Revert "Add Operations API""""" This reverts commit 9f55eb4c399eb48a8578906f6bea43b10c91b8be. * Address review comment from ARM * Revert "Address review comment from ARM" This reverts commit cb6d1b01860de72eec80856f64b602c72a1f26a7. * Revert "Revert "Address review comment from ARM"" This reverts commit 227cf73797ee24a674d76e3ccd2990b84bc8d11a. * Revert "Revert "Revert "Revert "Revert "Revert "Add Operations API"""""" This reverts commit 34ae6c70a514e0290ffb41f7ddb5bbbd5c6cbee3. * Revert "Revert "Revert "Revert "Revert "Revert "Revert "Add Operations API""""""" This reverts commit a11c889a65b0fa4257b03a247d75fbea769f4e2c. * Add previous APIs to tag * Retrigger build * fix service name for Java (#13979) * Add optional param - private DNS zone to server API (#13716) * Add optional param - private DNS zone to server API * Follow comment to resolve go sdk issue. * [Hub Generated] Review request for Microsoft.Synapse to add version preview/2021-04-01-preview (#13874) * Adds base for updating Microsoft.Synapse from version stable/2021-03-01 to version 2021-04-01-preview * Updates readme * Updates API version in new specs and examples * add changed files for kustoPool * Ravi changes to fix LinDiff validation * Add Itay Sofer's changes * filizt comments mid-way * Remove clouderror and resplace with "../../../../../common-types/resource-management/v2/types.json#/definitions/ErrorResponse" * Add IotHubDataConnection and EventGridDataConnection * Modify PUT to OK, CREATED, ACCEPTED * Change from provisioningState to ResourceProvisioningState * Add BlobStorageEventType * Remove 202 when creating a KustoPool * Change PUT/PATCH 202 responses * Remove 202 in PATCH/PUT operations where having both 200 & 201 * Add "isIdentityCertExprired" to custom-words.txt * Remove isIdentityCertExprired from custom-words.txt * Add Exprired to cSpell.json Co-authored-by: Amit Elran <amelran@microsoft.com> * Removing x-ms-flatten property (#13929) * manual changes for swagger * changes for long-running operations * changes for validate for backup and restore * removing 204 from operationResults * changes for a monitoring * adding format * removing date-time from duration * changing to readonly * changes for listRPs * fixes swagger * reverting readonly for scheduleTimes * fixes for checkgates * prettier fixes * cahnges for friendlyname checks * fixing gates * removing tracking-via * model validation fixes * powershell changes * adding stable version * changes for PatchResourceRequestInput * change for req fields * changes for description * changes * Updated swagger json for item level restore target info objects * Fixed spelling errors * Added missing required properties * removed auth credentials property * prettier fixes * Prettier fix * pr comments fixes * fixing readme * changes for go readme * Removed x-ms-flatten property (#2) * removed flatten prop * removing x-ms-flatten * removing friendlyName from req prop Co-authored-by: Mayank Aggarwal <mayaggar@microsoft.com> Co-authored-by: Mayank Aggarwal <mayaggar@microsoft.com> Co-authored-by: FAREAST\zakinkh <zakinkh@microsoft.com> * confidentialledger readme t2 config (#13981) * Additional 7.3-preview parameter name clean up (#13913) * Enable multivariate anomaly detection (#13973) * add multivarite * add v1.1-preview * reformat changepoint example * change typo in readme * fix prettier-check error * add export model example * fix prettier error * [Azure Search] Add Knowledge Store feature to swagger (#13911) * introduce knowledge store swagger * add knowledge store to 2020 apis Co-authored-by: Austin Drefke <jdrefke@microsoft.com> * make skillset count optional, and add it to 2020 GA Swagger (#13990) Co-authored-by: Austin Drefke <jdrefke@microsoft.com> * Adding support for message properties in ACS Chat (#13939) * Initial commit (copying over stable API version) * Making changes to support message metadata * Added 201 response code for patch operation (#13956) Co-authored-by: Akash Keshari <akkeshar@microsoft.com> * Adding autoMitigate flag with false as default value (#13109) * deploymentmanager - clean up duplicate parameters outside of method (#13948) * clean up duplicate parameters outside of method * maintain python order * fix typo in Synapse (#13994) * OperationalInsights - update readme files for cli extension update (#13999) * added3 new properties to TableProperties: IsTroubleshootingAllowed, IsTroubleshootingEnabled, IsTroubleshootingEnabledLastActivation. * added Tables new api version * changed bool to boolean types * prettified jsons * fix erroes in swagger * undo changes to 2020-03-01-preview version * pr fixes * updated TableUpdate example * changed lastTroubleshootDate from date format to string, removed isTroubleshootingAllowed from body of example * changed v1 to v2 * changed WorkspaceNameParameter back to V1 * changed ErrorResponse to default ErrorResponse without ref to local definition * added systemData * removed systemData * added systemData to Patch and Get * moved systemData to Table properties * deleted systemData from Table.json, added to Get and Put examles * changed location of systemData in Tables.json * moved systemData to inside Table definition * moved systemData inside Table properties * removed SystemData * creatted a new package containing all latest swagger files for publishing new SDK * removed package 2021_02 and set default packate to 2020_10 * removed 2 packages * removed DataCollectorLogs.json from readme.md 20202.10 * added empty line to try invoke pipeline validations that havent run * Delete Tables.json * added3 new properties to TableProperties: IsTroubleshootingAllowed, IsTroubleshootingEnabled, IsTroubleshootingEnabledLastActivation. * merge * prettified jsons * undo changes to 2020-03-01-preview version * updated TableUpdate example * changed lastTroubleshootDate from date format to string, removed isTroubleshootingAllowed from body of example * changed v1 to v2 * changed WorkspaceNameParameter back to V1 * added systemData * removed systemData * added systemData to Patch and Get * moved systemData to Table properties * deleted systemData from Table.json, added to Get and Put examles * changed location of systemData in Tables.json * moved systemData to inside Table definition * moved systemData inside Table properties * removed whitespaces * changed DataExportErrorResponse to common .../v2/types.json#/definitions/ErrorResponse * changed all Error response of 2020-08 to common definition * added readme.az.md file for cli extension code generator * added readme.ad.md with the same naming convention as in readme.python.md added readme.cli.md file updatted readme.md file with the new azure-cli-extensions tag all updates were done by following: https://github.com/Azure/autorest.az/blob/9ed1aabd353385f8bdffbfa9f3892478111a029c/doc/how-to-author-readme-file.md * Update specification/operationalinsights/resource-manager/readme.az.md Co-authored-by: Qiaoqiao Zhang <55688292+qiaozha@users.noreply.github.com> * Update specification/operationalinsights/resource-manager/readme.az.md Co-authored-by: Qiaoqiao Zhang <55688292+qiaozha@users.noreply.github.com> * Update specification/operationalinsights/resource-manager/readme.az.md Co-authored-by: Qiaoqiao Zhang <55688292+qiaozha@users.noreply.github.com> * Update specification/operationalinsights/resource-manager/readme.az.md Co-authored-by: Qiaoqiao Zhang <55688292+qiaozha@users…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.