Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

az.getSecret() helper for bicepparam files #10776

Closed
wants to merge 16 commits into from
Closed

az.getSecret() helper for bicepparam files #10776

wants to merge 16 commits into from

Conversation

polatengin
Copy link
Member

@polatengin polatengin commented May 22, 2023 •
edited
Loading

Contributing a feature

  • I have opened a new issue for the proposal, or commented on an existing one, and ensured that the Bicep maintainers are good with the design of the feature being implemented
  • I have included "Fixes #{issue_number}" in the PR description, so GitHub can link to the issue and close it when the PR is merged
  • I have appropriate test coverage of my new feature

This PR is based off from #10726 to re-use the changes/structures defined there
Changes specific for this feature can be found in this commit; 6dd69cb
Integration Tests added for the changes can be found in this commit; af2fcde

Design Proposal for the getSecret() support in .bicepparam files can be found on; #10652 (comment)

Microsoft Reviewers: Open in CodeFlow

HadwaAbdelhalem and others added 14 commits May 16, 2023 10:55
@polatengin polatengin self-assigned this May 22, 2023
@polatengin polatengin changed the title getsecret() helper bicepparam files getsecret() helper for bicepparam files May 22, 2023
@polatengin polatengin requested a review from Usman0111 May 22, 2023 19:03
@polatengin polatengin changed the title getsecret() helper for bicepparam files az.getSecret() helper for bicepparam files May 29, 2023
@polatengin polatengin closed this Jun 2, 2023
@polatengin polatengin deleted the enpolat/getsecret-helper-bicepparam-files branch July 14, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Usman0111 Usman0111 Awaiting requested review from Usman0111

Assignees

@polatengin polatengin

Labels
story: bicep parameters
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@polatengin @HadwaAbdelhalem