Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapse target union types before narrowing #10987

Merged
merged 2 commits into from
Jun 19, 2023
Merged

Collapse target union types before narrowing #10987

merged 2 commits into from
Jun 19, 2023

Conversation

jeskew
Copy link
Member

@jeskew jeskew commented Jun 15, 2023

Resolves #10098

When narrowing types, we should collapse unions as an early first step. This is primarily done to enhance constraint checks and error messaging

Microsoft Reviewers: Open in CodeFlow

@jeskew jeskew requested a review from a team June 15, 2023 17:32
@github-actions
Copy link
Contributor

github-actions bot commented Jun 15, 2023

Test Results (linux-x64)

       33 files  ±0         33 suites  ±0   36m 17s ⏱️ + 3m 10s
10 066 tests +1  10 066 ✔️ +1  0 💤 ±0  0 ±0 
12 282 runs  +1  12 282 ✔️ +1  0 💤 ±0  0 ±0 

Results for commit 77dab8c. ± Comparison against base commit 6f98adc.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 15, 2023

Test Results (win-x64)

       33 files  ±0         33 suites  ±0   29m 50s ⏱️ - 2m 57s
10 078 tests +1  10 078 ✔️ +1  0 💤 ±0  0 ±0 
12 293 runs  +1  12 293 ✔️ +1  0 💤 ±0  0 ±0 

Results for commit 77dab8c. ± Comparison against base commit 6f98adc.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 15, 2023

Test Results (osx-x64)

       33 files  ±0         33 suites  ±0   1h 36m 14s ⏱️ + 10m 4s
10 070 tests +1  10 070 ✔️ +1  0 💤 ±0  0 ±0 
12 286 runs  +1  12 286 ✔️ +1  0 💤 ±0  0 ±0 

Results for commit 77dab8c. ± Comparison against base commit 6f98adc.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 15, 2023

Test Results (linux-musl-x64)

       33 files  ±0         33 suites  ±0   28m 25s ⏱️ +28s
10 066 tests +1  10 066 ✔️ +1  0 💤 ±0  0 ±0 
12 282 runs  +1  12 282 ✔️ +1  0 💤 ±0  0 ±0 

Results for commit 77dab8c. ± Comparison against base commit 6f98adc.

♻️ This comment has been updated with latest results.

@jeskew jeskew merged commit efa5eca into main Jun 19, 2023
@jeskew jeskew deleted the jeskew/10098 branch June 19, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calculated parameter value not valid according to allowed values
2 participants