Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restores user defined tagged unions feature #11535

Merged
merged 6 commits into from
Aug 29, 2023
Merged

Restores user defined tagged unions feature #11535

merged 6 commits into from
Aug 29, 2023

Conversation

kalbert312
Copy link
Member

@kalbert312 kalbert312 commented Aug 15, 2023

Fixes #9230

Reenables the feature.

Microsoft Reviewers: Open in CodeFlow

Verified

This commit was signed with the committer’s verified signature.
Doctor-wu Doctor Wu

Verified

This commit was signed with the committer’s verified signature.
Doctor-wu Doctor Wu

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@kalbert312 kalbert312 requested a review from jeskew August 15, 2023 14:14
@github-actions
Copy link
Contributor

github-actions bot commented Aug 15, 2023

Test Results (win-x64)

       33 files  ±0         33 suites  ±0   40m 1s ⏱️ + 6m 32s
10 430 tests ±0  10 430 ✔️ +36  0 💤  - 36  0 ±0 
12 646 runs  ±0  12 646 ✔️ +36  0 💤  - 36  0 ±0 

Results for commit 225fd08. ± Comparison against base commit 744dd34.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 15, 2023

Test Results (linux-x64)

       33 files  ±0         33 suites  ±0   37m 29s ⏱️ + 3m 25s
10 418 tests ±0  10 418 ✔️ +36  0 💤  - 36  0 ±0 
12 635 runs  ±0  12 635 ✔️ +36  0 💤  - 36  0 ±0 

Results for commit 225fd08. ± Comparison against base commit 744dd34.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 15, 2023

Test Results (osx-x64)

       33 files  ±0         33 suites  ±0   1h 33m 16s ⏱️ - 4m 59s
10 422 tests ±0  10 422 ✔️ +36  0 💤  - 36  0 ±0 
12 639 runs  ±0  12 639 ✔️ +36  0 💤  - 36  0 ±0 

Results for commit 225fd08. ± Comparison against base commit 744dd34.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 15, 2023

Test Results (linux-musl-x64)

       33 files  ±0         33 suites  ±0   37m 40s ⏱️ + 1m 10s
10 418 tests ±0  10 418 ✔️ +36  0 💤  - 36  0 ±0 
12 635 runs  ±0  12 635 ✔️ +36  0 💤  - 36  0 ±0 

Results for commit 225fd08. ± Comparison against base commit 744dd34.

♻️ This comment has been updated with latest results.

@kalbert312 kalbert312 marked this pull request as ready for review August 15, 2023 14:45
@jeskew
Copy link
Member

jeskew commented Aug 15, 2023

Should we leave this in draft or with do-not-merge until w32 finishes rolling out? Otherwise, LGTM.

@kalbert312
Copy link
Member Author

Should we leave this in draft or with do-not-merge until w32 finishes rolling out? Otherwise, LGTM.

Adding "do-not-merge" until w32 rolls out.

@kalbert312 kalbert312 added the do not merge Do not merge this pull request yet. label Aug 15, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
# Conflicts:
#	src/Bicep.Core.Samples/Files/TypeDeclarations_LF/main.ir.bicep
#	src/Bicep.Core.Samples/Files/TypeDeclarations_LF/main.json
#	src/Bicep.Core.Samples/Files/TypeDeclarations_LF/main.symbolicnames.json
#	src/Bicep.Core.Samples/Files/TypeDeclarations_LF/main.syntax.bicep

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@kalbert312 kalbert312 removed the do not merge Do not merge this pull request yet. label Aug 29, 2023
@kalbert312 kalbert312 merged commit 97773aa into main Aug 29, 2023
@kalbert312 kalbert312 deleted the kylea/9230-2 branch August 29, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tagged union type declarations
2 participants