Decorators

src/Bicep.Core.IntegrationTests/Emit/TemplateEmitterTests.cs

@@ -52,7 +52,7 @@ public void ValidBicep_TemplateEmiterShouldProduceExpectedTemplate(DataSet dataS
         [TestMethod]
         public void TemplateEmitter_output_should_not_include_UTF8_BOM()
         {
-            var syntaxTreeGrouping = SyntaxFactory.CreateFromText("");
+            var syntaxTreeGrouping = SyntaxTreeGroupingFactory.CreateFromText("");
             var compiledFilePath = FileHelper.GetResultFilePath(this.TestContext, "main.json");
 
             // emitting the template should be successful

src/Bicep.Core.IntegrationTests/ModuleTests.cs

@@ -72,7 +72,7 @@ param inputb string
             };
 
 
-            var compilation = new Compilation(TestResourceTypeProvider.Create(), SyntaxFactory.CreateForFiles(files, mainUri));
+            var compilation = new Compilation(TestResourceTypeProvider.Create(), SyntaxTreeGroupingFactory.CreateForFiles(files, mainUri));
 
             var (success, diagnosticsByFile) = GetSuccessAndDiagnosticsByFile(compilation);
             diagnosticsByFile.Values.SelectMany(x => x).Should().BeEmpty();
@@ -102,7 +102,7 @@ param inputb string
             };
 
 
-            var compilation = new Compilation(TestResourceTypeProvider.Create(), SyntaxFactory.CreateForFiles(files, mainUri));
+            var compilation = new Compilation(TestResourceTypeProvider.Create(), SyntaxTreeGroupingFactory.CreateForFiles(files, mainUri));
 
             var (success, diagnosticsByFile) = GetSuccessAndDiagnosticsByFile(compilation);
             diagnosticsByFile[mainUri].Should().HaveDiagnostics(new[] {
@@ -157,7 +157,7 @@ param inputb string
             };
 
 
-            var compilation = new Compilation(TestResourceTypeProvider.Create(), SyntaxFactory.CreateForFiles(files, mainUri));
+            var compilation = new Compilation(TestResourceTypeProvider.Create(), SyntaxTreeGroupingFactory.CreateForFiles(files, mainUri));
 
             var (success, diagnosticsByFile) = GetSuccessAndDiagnosticsByFile(compilation);
             diagnosticsByFile[mainUri].Should().HaveDiagnostics(new[] {

src/Bicep.Core.IntegrationTests/Semantics/CompilationTests.cs

@@ -15,7 +15,7 @@ public class CompilationTests
         [TestMethod]
         public void EmptyProgram_SyntaxTreeGrouping_should_be_persisted()
         {
-            var program = SyntaxFactory.CreateFromText(DataSets.Empty.Bicep);
+            var program = SyntaxTreeGroupingFactory.CreateFromText(DataSets.Empty.Bicep);
             var compilation = new Compilation(TestResourceTypeProvider.Create(), program);
 
             compilation.SyntaxTreeGrouping.Should().BeSameAs(program);

src/Bicep.Core.IntegrationTests/Semantics/SemanticModelTests.cs

@@ -47,7 +47,7 @@ public void ProgramsShouldProduceExpectedDiagnostics(DataSet dataSet)
         [TestMethod]
         public void EndOfFileFollowingSpaceAfterParameterKeyWordShouldNotThrow()
         {
-            var compilation = new Compilation(TestResourceTypeProvider.Create(), SyntaxFactory.CreateFromText("parameter "));
+            var compilation = new Compilation(TestResourceTypeProvider.Create(), SyntaxTreeGroupingFactory.CreateFromText("parameter "));
             compilation.GetEntrypointSemanticModel().GetParseDiagnostics();
         }
 

src/Bicep.Core.IntegrationTests/TypeSystem/TypeValidationTests.cs

@@ -23,7 +23,7 @@ private static SemanticModel GetSemanticModelForTest(string programText, IEnumer
         {
             var typeProvider = ResourceTypeProviderHelper.CreateMockTypeProvider(definedTypes);
 
-            var compilation = new Compilation(typeProvider, SyntaxFactory.CreateFromText(programText));
+            var compilation = new Compilation(typeProvider, SyntaxTreeGroupingFactory.CreateFromText(programText));
             return compilation.GetEntrypointSemanticModel();
         }
 

src/Bicep.Core.Samples/Files/InvalidModules_LF/main.bicep

@@ -231,3 +231,9 @@ module moduleWithDuplicateName1 './empty.bicep' = {
 module moduleWithDuplicateName2 './empty.bicep' = {
   name: 'moduleWithDuplicateName'
 }
+
+//@az.secure()
+@minValue()
+module moduleWithNotAttachableDecorators './empty.bicep' = {
+  name: 'moduleWithNotAttachableDecorators'
+}

src/Bicep.Core.Samples/Files/InvalidModules_LF/main.diagnostics.bicep

@@ -307,3 +307,10 @@ module moduleWithDuplicateName2 './empty.bicep' = {
 //@[8:33) [BCP122 (Error)] Modules: "moduleWithDuplicateName1", "moduleWithDuplicateName2" are defined with this same name and this same scope in a file. Rename them or split into different modules. |'moduleWithDuplicateName'|
 }
 
+//@az.secure()
+@minValue()
+//@[1:9) [BCP128 (Error)] Function "minValue" cannot be used as a module decorator. |minValue|
+module moduleWithNotAttachableDecorators './empty.bicep' = {
+  name: 'moduleWithNotAttachableDecorators'
+}
+

src/Bicep.Core.Samples/Files/InvalidModules_LF/main.formatted.bicep

@@ -199,3 +199,9 @@ module moduleWithDuplicateName1 './empty.bicep' = {
 module moduleWithDuplicateName2 './empty.bicep' = {
   name: 'moduleWithDuplicateName'
 }
+
+//@az.secure()
+@minValue()
+module moduleWithNotAttachableDecorators './empty.bicep' = {
+  name: 'moduleWithNotAttachableDecorators'
+}

src/Bicep.Core.Samples/Files/InvalidModules_LF/main.symbols.bicep

@@ -288,3 +288,10 @@ module moduleWithDuplicateName2 './empty.bicep' = {
   name: 'moduleWithDuplicateName'
 }
 
+//@az.secure()
+@minValue()
+module moduleWithNotAttachableDecorators './empty.bicep' = {
+//@[7:40) Module moduleWithNotAttachableDecorators. Type: module. Declaration start char: 0, length: 118
+  name: 'moduleWithNotAttachableDecorators'
+}
+

src/Bicep.Core.Samples/Files/InvalidModules_LF/main.syntax.bicep

@@ -1463,6 +1463,40 @@ module moduleWithDuplicateName2 './empty.bicep' = {
 //@[33:34)   NewLine |\n|
 }
 //@[0:1)   RightBrace |}|
+//@[1:3) NewLine |\n\n|
+
+//@az.secure()
+//@[14:15) NewLine |\n|
+@minValue()
+//@[0:118) ModuleDeclarationSyntax
+//@[0:11)  DecoratorSyntax
+//@[0:1)   At |@|
+//@[1:11)   FunctionCallSyntax
+//@[1:9)    IdentifierSyntax
+//@[1:9)     Identifier |minValue|
+//@[9:10)    LeftParen |(|
+//@[10:11)    RightParen |)|
+//@[11:12)  NewLine |\n|
+module moduleWithNotAttachableDecorators './empty.bicep' = {
+//@[0:6)  Identifier |module|
+//@[7:40)  IdentifierSyntax
+//@[7:40)   Identifier |moduleWithNotAttachableDecorators|
+//@[41:56)  StringSyntax
+//@[41:56)   StringComplete |'./empty.bicep'|
+//@[57:58)  Assignment |=|
+//@[59:106)  ObjectSyntax
+//@[59:60)   LeftBrace |{|
+//@[60:61)   NewLine |\n|
+  name: 'moduleWithNotAttachableDecorators'
+//@[2:43)   ObjectPropertySyntax
+//@[2:6)    IdentifierSyntax
+//@[2:6)     Identifier |name|
+//@[6:7)    Colon |:|
+//@[8:43)    StringSyntax
+//@[8:43)     StringComplete |'moduleWithNotAttachableDecorators'|
+//@[43:44)   NewLine |\n|
+}
+//@[0:1)   RightBrace |}|
 //@[1:2) NewLine |\n|
 
 //@[0:0) EndOfFile ||

src/Bicep.Core.Samples/Files/InvalidModules_LF/main.tokens.bicep

@@ -962,6 +962,30 @@ module moduleWithDuplicateName2 './empty.bicep' = {
 //@[33:34) NewLine |\n|
 }
 //@[0:1) RightBrace |}|
+//@[1:3) NewLine |\n\n|
+
+//@az.secure()
+//@[14:15) NewLine |\n|
+@minValue()
+//@[0:1) At |@|
+//@[1:9) Identifier |minValue|
+//@[9:10) LeftParen |(|
+//@[10:11) RightParen |)|
+//@[11:12) NewLine |\n|
+module moduleWithNotAttachableDecorators './empty.bicep' = {
+//@[0:6) Identifier |module|
+//@[7:40) Identifier |moduleWithNotAttachableDecorators|
+//@[41:56) StringComplete |'./empty.bicep'|
+//@[57:58) Assignment |=|
+//@[59:60) LeftBrace |{|
+//@[60:61) NewLine |\n|
+  name: 'moduleWithNotAttachableDecorators'
+//@[2:6) Identifier |name|
+//@[6:7) Colon |:|
+//@[8:43) StringComplete |'moduleWithNotAttachableDecorators'|
+//@[43:44) NewLine |\n|
+}
+//@[0:1) RightBrace |}|
 //@[1:2) NewLine |\n|
 
 //@[0:0) EndOfFile ||

src/Bicep.Core.Samples/Files/InvalidOutputs_CRLF/main.bicep

@@ -95,3 +95,7 @@ output exp string = 2 + 3
 output union string = true ? 's' : 1
 output bad int = true && !4
 output deeper bool = true ? -true : (14 && 's') + 10
+
+@az.maxValue(20)
+@minValue(10)
+output notAttachableDecorators int = 32

src/Bicep.Core.Samples/Files/InvalidOutputs_CRLF/main.diagnostics.bicep

@@ -176,3 +176,9 @@ output deeper bool = true ? -true : (14 && 's') + 10
 //@[28:33) [BCP044 (Error)] Cannot apply operator "-" to operand of type "bool". |-true|
 //@[37:46) [BCP045 (Error)] Cannot apply operator "&&" to operands of type "int" and "'s'". |14 && 's'|
 
+@az.maxValue(20)
+//@[4:12) [BCP129 (Error)] Function "maxValue" cannot be used as an output decorator. |maxValue|
+@minValue(10)
+//@[1:9) [BCP129 (Error)] Function "minValue" cannot be used as an output decorator. |minValue|
+output notAttachableDecorators int = 32
+

src/Bicep.Core.Samples/Files/InvalidOutputs_CRLF/main.formatted.bicep

@@ -87,3 +87,7 @@ output exp string = 2 + 3
 output union string = true ? 's' : 1
 output bad int = true && !4
 output deeper bool = true ? -true : (14 && 's') + 10
+
+@az.maxValue(20)
+@minValue(10)
+output notAttachableDecorators int = 32

src/Bicep.Core.Samples/Files/InvalidOutputs_CRLF/main.symbols.bicep

@@ -140,3 +140,8 @@ output bad int = true && !4
 output deeper bool = true ? -true : (14 && 's') + 10
 //@[7:13) Output deeper. Type: bool. Declaration start char: 0, length: 52
 
+@az.maxValue(20)
+@minValue(10)
+output notAttachableDecorators int = 32
+//@[7:30) Output notAttachableDecorators. Type: int. Declaration start char: 0, length: 72
+

src/Bicep.Core.Samples/Files/InvalidOutputs_CRLF/main.syntax.bicep

@@ -598,6 +598,46 @@ output deeper bool = true ? -true : (14 && 's') + 10
 //@[48:49)    Plus |+|
 //@[50:52)    NumericLiteralSyntax
 //@[50:52)     Number |10|
-//@[52:54) NewLine |\r\n|
+//@[52:56) NewLine |\r\n\r\n|
+
+@az.maxValue(20)
+//@[0:72) OutputDeclarationSyntax
+//@[0:16)  DecoratorSyntax
+//@[0:1)   At |@|
+//@[1:16)   InstanceFunctionCallSyntax
+//@[1:3)    VariableAccessSyntax
+//@[1:3)     IdentifierSyntax
+//@[1:3)      Identifier |az|
+//@[3:4)    Dot |.|
+//@[4:12)    IdentifierSyntax
+//@[4:12)     Identifier |maxValue|
+//@[12:13)    LeftParen |(|
+//@[13:15)    FunctionArgumentSyntax
+//@[13:15)     NumericLiteralSyntax
+//@[13:15)      Number |20|
+//@[15:16)    RightParen |)|
+//@[16:18)  NewLine |\r\n|
+@minValue(10)
+//@[0:13)  DecoratorSyntax
+//@[0:1)   At |@|
+//@[1:13)   FunctionCallSyntax
+//@[1:9)    IdentifierSyntax
+//@[1:9)     Identifier |minValue|
+//@[9:10)    LeftParen |(|
+//@[10:12)    FunctionArgumentSyntax
+//@[10:12)     NumericLiteralSyntax
+//@[10:12)      Number |10|
+//@[12:13)    RightParen |)|
+//@[13:15)  NewLine |\r\n|
+output notAttachableDecorators int = 32
+//@[0:6)  Identifier |output|
+//@[7:30)  IdentifierSyntax
+//@[7:30)   Identifier |notAttachableDecorators|
+//@[31:34)  TypeSyntax
+//@[31:34)   Identifier |int|
+//@[35:36)  Assignment |=|
+//@[37:39)  NumericLiteralSyntax
+//@[37:39)   Number |32|
+//@[39:41) NewLine |\r\n|
 
 //@[0:0) EndOfFile ||

src/Bicep.Core.Samples/Files/InvalidOutputs_CRLF/main.tokens.bicep

@@ -391,6 +391,30 @@ output deeper bool = true ? -true : (14 && 's') + 10
 //@[46:47) RightParen |)|
 //@[48:49) Plus |+|
 //@[50:52) Number |10|
-//@[52:54) NewLine |\r\n|
+//@[52:56) NewLine |\r\n\r\n|
+
+@az.maxValue(20)
+//@[0:1) At |@|
+//@[1:3) Identifier |az|
+//@[3:4) Dot |.|
+//@[4:12) Identifier |maxValue|
+//@[12:13) LeftParen |(|
+//@[13:15) Number |20|
+//@[15:16) RightParen |)|
+//@[16:18) NewLine |\r\n|
+@minValue(10)
+//@[0:1) At |@|
+//@[1:9) Identifier |minValue|
+//@[9:10) LeftParen |(|
+//@[10:12) Number |10|
+//@[12:13) RightParen |)|
+//@[13:15) NewLine |\r\n|
+output notAttachableDecorators int = 32
+//@[0:6) Identifier |output|
+//@[7:30) Identifier |notAttachableDecorators|
+//@[31:34) Identifier |int|
+//@[35:36) Assignment |=|
+//@[37:39) Number |32|
+//@[39:41) NewLine |\r\n|
 
 //@[0:0) EndOfFile ||