Skip to content

Add tests for duplicate semantic tokens #1485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 26, 2021

Conversation

anthony-c-martin
Copy link
Member

Contributing a Pull Request

If you haven't already, read the full contribution guide. The guide may have changed since the last time you read it, so please double-check. Once you are done and ready to submit your PR, run through the relevant checklist below.

Fixes #1428

@anthony-c-martin
Copy link
Member Author

Raised OmniSharp/csharp-language-server-protocol#516 to try and figure out the exception in the semantic tokens test.

@anthony-c-martin anthony-c-martin changed the title Fix for duplicate semantic tokens Add tests for duplicate semantic tokens Feb 9, 2021
@majastrz
Copy link
Member

Does this work ok with O# 19 now?

Copy link
Contributor

@shenglol shenglol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@anthony-c-martin anthony-c-martin merged commit 662cbcd into main May 26, 2021
@anthony-c-martin anthony-c-martin deleted the antmarti/overlapping_tokens branch May 26, 2021 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tags values missing color syntax
3 participants