-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wait and Retry decorators with Experimental Feature Flag Enabled #16167
Conversation
Test this change out locally with the following install scripts (Action run 13120868645) VSCode
Azure CLI
|
Dotnet Test Results 78 files - 39 78 suites - 39 32m 36s ⏱️ - 15m 11s Results for commit 854e85c. ± Comparison against base commit 3c802a3. This pull request removes 1870 and adds 717 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…decorators (#16342) This is an incremental PR that introduces the `WaitUntil` and `RetryOn` decorators to the Bicep language. The PR introduces changes for the following decorators. WaitUntil is used on resource data type. RetryOnAll and WaitUntilAll are decorators used on collection resource data type. Context: Users are facing issues with certain RPs (example SRP), where due to latency in replication or RP itself responded with success even before the resource is ready for use. In such a case, dependent resource deployments fail, because the resource isn't available according to ARM or some properties of the resource isn't available like list keys for example. #1013 for reference. Previous PR #16167 ###### Microsoft Reviewers: [Open in CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/Azure/bicep/pull/16342) --------- Co-authored-by: Subha Sambandamurthy <susamban@microsoft.com>
Users are facing issues with certain RPs (example SRP), where due to latency in replication or RP itself responded with success even before the resource is ready for use.
In such a case, dependent resource deployments fail, because the resource isn't available according to ARM or some properties of the resource isn't available like list keys for example. Issue thread for reference.
For overcoming this issue WaitUntil and RetryOn decorators are being introduced, that can apply to resource types. WaitUntil, will wait for the resource to be ready until certain properties are set to desired value, while RetryOn will retry the resource deployment when listed error codes are encountered
Microsoft Reviewers: Open in CodeFlow