-
Notifications
You must be signed in to change notification settings - Fork 808
Draft PR: Implement fixed scope parameter serializer and remove bandaid #18268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
harshpatel17
wants to merge
1
commit into
main
Choose a base branch
from
harsh/fixAndRemoveBandaid
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Test this change out locally with the following install scripts (Action run 18565104590) VSCode
Azure CLI
|
Contributor
Dotnet Test Results 96 files - 48 96 suites - 48 42m 44s ⏱️ - 22m 10s Results for commit 45c3928. ± Comparison against base commit d8b8c9e. This pull request removes 1920 and adds 652 tests. Note that renamed tests count towards both. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed the temporary bandaid to handle 3 failing LocalDeployCommand tests. These tests were initially failing because when ResourceType was serialized with modern scope properties, the serializer incorrectly included null legacy scope properties.
This causes extension resources like request@v1 to be incorrectly flagged as ReadOnly, triggering BCP245 errors:
"Resource type 'request@v1' can only be used with the 'existing' keyword" in LocalDeployCommand tests.
The serializer was fixed in bicep-types and this PR also makes the update to that newest version.
Example Usage
Checklist
Microsoft Reviewers: Open in CodeFlow