Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flow dependsOn detection through 'existing' resource definitions #1991

Merged
merged 3 commits into from
Mar 24, 2021
Merged

Flow dependsOn detection through 'existing' resource definitions #1991

merged 3 commits into from
Mar 24, 2021

Conversation

anthony-c-martin
Copy link
Member

Fixes #1986

@majastrz
Copy link
Member

We should be putting an actual description of the fix into the PR description and/or title. If we ever need to go back and check history, "This fixes issue x" will make it harder to figure out what changed or just force you into git grep.

majastrz
majastrz approved these changes Mar 23, 2021
View reviewed changes
Copy link
Member

@majastrz majastrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed off with comments.

@anthony-c-martin anthony-c-martin changed the title Fix for issue 1986 Flow dependsOn detection through 'existing' resource definitions Mar 24, 2021
@anthony-c-martin
Copy link
Member Author

We should be putting an actual description of the fix into the PR description and/or title. If we ever need to go back and check history, "This fixes issue x" will make it harder to figure out what changed or just force you into git grep.

Good point, updated

@anthony-c-martin anthony-c-martin enabled auto-merge (squash) March 24, 2021 09:46
@anthony-c-martin anthony-c-martin merged commit 091f527 into main Mar 24, 2021
@anthony-c-martin anthony-c-martin deleted the antmarti/issue1986 branch March 24, 2021 10:22
This was referenced Jan 31, 2022
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majastrz majastrz majastrz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DependsOn detection does not flow through existing resource definitions
2 participants
@anthony-c-martin @majastrz