var loops and completion fixes #2077

majastrz · 2021-03-31T04:16:45Z

Changes:

Added variable loops (this fixes Implement variable loops #1814). Variable loops cannot depend on runtime functions such as list*() or reference() and cannot retrieve a property of another resource. An error diagnostic listing the variable dependency chain is emitted in this case.
Added variable loop snippets
Fixed parameter value and output value snippets to be more consistent with property value snippets of the same type (this fixes Output loop snippets are missing #2073). None of this is introducing any new capabilities - just reusing existing code better.

Variable Loops

Variable completions

Parameter completions

(The {} completion was missing before.)

Output completions

(The [] completion and loop snippets were missing before.)

majastrz · 2021-03-31T04:19:07Z

src/Bicep.Core/Emit/ExpressionEmitter.cs

@@ -174,6 +174,25 @@ public void EmitLanguageExpression(SyntaxBase syntax)

        public void EmitCopyObject(string? name, ForSyntax syntax, SyntaxBase? input, string? copyIndexOverride = null, long? batchSize = null)
        {
+            // local function
+            static bool CanEmitAsInputDirectly(SyntaxBase input)


CanEmitAsInputDirectly [](start = 24, length = 22)

I have an internal task to fix this in the runtime, so the workarounds aren't needed anymore.

majastrz · 2021-03-31T04:21:19Z

src/Bicep.Core.Samples/Files/Variables_LF/main.json

@@ -24,6 +24,57 @@
  },
  "functions": [],
  "variables": {
+    "copy": [


copy [](start = 5, length = 4)

I've deployed a template that compiled to this addition and it worked.

var loops and completion fixes

df5713f

majastrz commented Mar 31, 2021

View reviewed changes

fixed newlines

177497a

majastrz marked this pull request as ready for review March 31, 2021 04:22

anthony-c-martin approved these changes Apr 1, 2021

View reviewed changes

majastrz merged commit 7492a04 into main Apr 1, 2021

majastrz deleted the majastrz/loopy-vars branch April 1, 2021 17:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

var loops and completion fixes #2077

var loops and completion fixes #2077

majastrz commented Mar 31, 2021

majastrz Mar 31, 2021

majastrz Mar 31, 2021

var loops and completion fixes #2077

var loops and completion fixes #2077

Conversation

majastrz commented Mar 31, 2021

Variable Loops

Variable completions

Parameter completions

Output completions

majastrz Mar 31, 2021

Choose a reason for hiding this comment

majastrz Mar 31, 2021

Choose a reason for hiding this comment